From: eregontp@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:96039] [Ruby master Feature#16294] Make MatchData frozen and forbid MatchData.allocate
Date: Sat, 30 Nov 2019 17:34:27 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-82889.20191130173426.6929a21dcd33a36d@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-16294.20191105125925@ruby-lang.org
Issue #16294 has been updated by Eregon (Benoit Daloze).
@nobu Thanks for the change! I'll adapt the specs.
----------------------------------------
Feature #16294: Make MatchData frozen and forbid MatchData.allocate
https://bugs.ruby-lang.org/issues/16294#change-82889
* Author: Eregon (Benoit Daloze)
* Status: Closed
* Priority: Normal
* Assignee:
* Target version:
----------------------------------------
Currently, `MatchData.allocate` is allowed, but almost every MatchData method called on it `raise TypeError, 'uninitialized Match'`.
I think MatchData should be frozen, none of its internal fields are mutable and I don't see any use case for storing instance variables on it.
Once frozen, we can implement MatchData#dup and #clone as just `return self`, and we don't need to check for the uninitialized case.
And Marshal can have special treatment to create an initialized MatchData directly.
My main motivation is looking at the code in TruffleRuby required to implement `MatchData.allocate` and check if it's initialized in so many places:
https://github.com/oracle/truffleruby/pull/1792/files
Thoughts? Anyone against?
cc @alanwu
--
https://bugs.ruby-lang.org/
prev parent reply other threads:[~2019-11-30 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-16294.20191105125925@ruby-lang.org>
2019-11-05 12:59 ` [ruby-core:95699] [Ruby master Feature#16294] Make MatchData frozen and forbid MatchData#allocate eregontp
2019-11-06 0:05 ` [ruby-core:95712] [Ruby master Feature#16294] Make MatchData frozen and forbid MatchData.allocate nobu
2019-11-06 1:11 ` [ruby-core:95717] " mame
2019-11-30 17:34 ` eregontp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-82889.20191130173426.6929a21dcd33a36d@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).