From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 6DD1C1F463 for ; Sun, 24 Nov 2019 14:08:19 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id EF8FA1209B5; Sun, 24 Nov 2019 23:08:04 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 3CA6E1209AB for ; Sun, 24 Nov 2019 23:08:02 +0900 (JST) Received: by filter0163p3mdw1.sendgrid.net with SMTP id filter0163p3mdw1-6892-5DDA8EC4-26 2019-11-24 14:08:04.929310913 +0000 UTC m=+396986.812944360 Received: from herokuapp.com (unknown [3.87.184.74]) by ismtpd0076p1mdw1.sendgrid.net (SG) with ESMTP id jF69FDCYRNexFJjG-O0j4A for ; Sun, 24 Nov 2019 14:08:04.867 +0000 (UTC) Date: Sun, 24 Nov 2019 14:08:04 +0000 (UTC) From: mame@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 71558 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16361 X-Redmine-Issue-Author: vo.x X-Redmine-Sender: mame X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?EJh2gqwnyqXtd++xo=2FinyA1V0bXouTB4FkWnzNiKb48sRluHFkyGcuOBgzbdht?= =?us-ascii?Q?U607zsT92a9LcQW+WtobEUXpF7rb1HU4aNrDN10?= =?us-ascii?Q?SZAw0CIG=2FuONq=2FVQUpH=2FFGmGmri005r6gCuRC+W?= =?us-ascii?Q?e5XGufuVK4e+ZJCKzwNGOwQ+3g1yacqSEzyvWh1?= =?us-ascii?Q?cWVZoTbV9tJSmJ2PPWiQEZm1+hTe5lGEHsw=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 95924 Subject: [ruby-core:95924] [Ruby master Bug#16361] TestEnv#test_fetch failure X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16361 has been updated by mame (Yusuke Endoh). I cannot reproduce the issue with ruby 2.7.0-preview3. ``` $ make test-all TESTS=test/ruby/test_env.rb fatal: not a git repository (or any of the parent directories): .git ./revision.h unchanged config.status: creating ruby-runner.h making mjit_build_dir.so Run options: "--ruby=./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems" --excludes-dir=./test/excludes --name=!/memory_leak/ # Running tests: Finished tests in 0.026560s, 1618.9994 tests/s, 40889.1485 assertions/s. 43 tests, 1086 assertions, 0 failures, 0 errors, 0 skips ruby -v: ruby 2.7.0preview3 (2019-11-22 master 35608760ff) [x86_64-linux] ``` Could you elaborate on what you did? ---------------------------------------- Bug #16361: TestEnv#test_fetch failure https://bugs.ruby-lang.org/issues/16361#change-82764 * Author: vo.x (Vit Ondruch) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.7.0dev (2019-11-22 master f9d20a1bf1) [x86_64-linux] * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN ---------------------------------------- I am facing following test suite error: ~~~ 1) Failure: TestEnv#test_fetch [/builddir/build/BUILD/ruby-2.7.0-f9d20a1bf1/test/ruby/test_env.rb:123]: [ruby-core:56062] [Feature #8649]. Expected Exception(KeyError) was raised, but the message doesn't match. <"key not found: \"test\""> expected but was <"key not found: \"test\"\n" + "Did you mean? \"TESTS\"">. ~~~ Trying to execute this test independently, it passes just fine. So it seems that the did_you_mean gem is loaded unexpectedly on this place. I just tried: ~~~ mv test/optparse/test_did_you_mean.rb{,.bak} ~~~ since this is the latest addition IMO and the test suite passes just fine. I am not really sure why it should fail on my setup and it probably does not fail in any other CI. Neither I am sure what would be the best option to fix this. The assertion could be updated to accept this message by simple sed: ~~~ sed -i "/'key not found: \"test\"'/ s/'/\//g" test/ruby/test_env.rb ~~~ -- https://bugs.ruby-lang.org/