From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 8F0271F463 for ; Sat, 23 Nov 2019 00:34:17 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id EF46E120969; Sat, 23 Nov 2019 09:34:02 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 1467412095D for ; Sat, 23 Nov 2019 09:34:00 +0900 (JST) Received: by filter0092p3las1.sendgrid.net with SMTP id filter0092p3las1-9756-5DD87E7D-B 2019-11-23 00:34:05.290443617 +0000 UTC m=+261495.190169517 Received: from herokuapp.com (unknown [54.224.109.234]) by ismtpd0027p1iad2.sendgrid.net (SG) with ESMTP id nTFqLS_JSaugRWTdMW7dKA for ; Sat, 23 Nov 2019 00:34:05.093 +0000 (UTC) Date: Sat, 23 Nov 2019 00:34:05 +0000 (UTC) From: mame@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 71548 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16361 X-Redmine-Issue-Author: vo.x X-Redmine-Sender: mame X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?EJh2gqwnyqXtd++xo=2FinyA1V0bXouTB4FkWnzNiKb4=2FBm7UfVbIgDOKZ0Kq3O2?= =?us-ascii?Q?Qu6A2dffgb4aIFmInZClkKRy6V7y4EiOROWOyTN?= =?us-ascii?Q?sTotPjzKWT7eOjN3ldjz8jxjyMcYcTetiwDm+vp?= =?us-ascii?Q?gkZ3zksr93UZbLttWg0fh4GzGwyvDCxj+FozUUa?= =?us-ascii?Q?RJriFDuX96IC6Ai7oQ6CadFxEJu9pPsU1bQ=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 95914 Subject: [ruby-core:95914] [Ruby master Bug#16361] TestEnv#test_fetch failure X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16361 has been updated by mame (Yusuke Endoh). How did you run the test? Currently, bundled gems should be unavailable in `make test-all`, and some tests don't assume that bundled gems are loaded. Currently, did_you_mean is a bundled gem, so should not be loaded in `make test-all`. [test/optparse/test_did_you_mean.rb](https://github.com/ruby/ruby/blob/818708edab6e950a8c1828816b73d36f05585f9f/test/optparse/test_did_you_mean.rb#L3) is disabled in effect: `require "did_you_mean" rescue return`. So this test file should not be loaded in the whole test suite run. We plan to convert did_you_mean to a default gem. Until the conversion, the test file will be disabled. ---------------------------------------- Bug #16361: TestEnv#test_fetch failure https://bugs.ruby-lang.org/issues/16361#change-82754 * Author: vo.x (Vit Ondruch) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.7.0dev (2019-11-22 master f9d20a1bf1) [x86_64-linux] * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN ---------------------------------------- I am facing following test suite error: ~~~ 1) Failure: TestEnv#test_fetch [/builddir/build/BUILD/ruby-2.7.0-f9d20a1bf1/test/ruby/test_env.rb:123]: [ruby-core:56062] [Feature #8649]. Expected Exception(KeyError) was raised, but the message doesn't match. <"key not found: \"test\""> expected but was <"key not found: \"test\"\n" + "Did you mean? \"TESTS\"">. ~~~ Trying to execute this test independently, it passes just fine. So it seems that the did_you_mean gem is loaded unexpectedly on this place. I just tried: ~~~ mv test/optparse/test_did_you_mean.rb{,.bak} ~~~ since this is the latest addition IMO and the test suite passes just fine. I am not really sure why it should fail on my setup and it probably does not fail in any other CI. Neither I am sure what would be the best option to fix this. The assertion could be updated to accept this message by simple sed: ~~~ sed -i "/'key not found: \"test\"'/ s/'/\//g" test/ruby/test_env.rb ~~~ -- https://bugs.ruby-lang.org/