* [ruby-core:95852] [Ruby master Bug#16349] Logger shift_age of 0 disables shift_size
[not found] <redmine.issue-16349.20191115004819@ruby-lang.org>
@ 2019-11-15 0:48 ` bughitgithub
2019-11-15 1:09 ` [ruby-core:95853] " hsbt
2019-11-18 1:39 ` [ruby-core:95873] " merch-redmine
2 siblings, 0 replies; 3+ messages in thread
From: bughitgithub @ 2019-11-15 0:48 UTC (permalink / raw
To: ruby-core
Issue #16349 has been reported by bughit (bug hit).
----------------------------------------
Bug #16349: Logger shift_age of 0 disables shift_size
https://bugs.ruby-lang.org/issues/16349
* Author: bughit (bug hit)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
* ruby -v:
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
shift_age is documented as: Number of old log files to keep, or frequency of rotation (daily, weekly or monthly). Default value is 0.
shift_size is documented: Maximum logfile size in bytes (only applies when shift_age is a number). Defaults to 1048576 (1MB).
Given the above, a shift_age of 0 should prevent the retention of old log files, but maximum size (shift_size) should still be enforced.
But it's not: https://github.com/ruby/ruby/blob/master/lib/logger/log_device.rb#L124
So either the behavior or the documentation is wrong.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ruby-core:95853] [Ruby master Bug#16349] Logger shift_age of 0 disables shift_size
[not found] <redmine.issue-16349.20191115004819@ruby-lang.org>
2019-11-15 0:48 ` [ruby-core:95852] [Ruby master Bug#16349] Logger shift_age of 0 disables shift_size bughitgithub
@ 2019-11-15 1:09 ` hsbt
2019-11-18 1:39 ` [ruby-core:95873] " merch-redmine
2 siblings, 0 replies; 3+ messages in thread
From: hsbt @ 2019-11-15 1:09 UTC (permalink / raw
To: ruby-core
Issue #16349 has been updated by hsbt (Hiroshi SHIBATA).
Assignee set to sonots (Naotoshi Seo)
Status changed from Open to Assigned
----------------------------------------
Bug #16349: Logger shift_age of 0 disables shift_size
https://bugs.ruby-lang.org/issues/16349#change-82686
* Author: bughit (bug hit)
* Status: Assigned
* Priority: Normal
* Assignee: sonots (Naotoshi Seo)
* Target version:
* ruby -v:
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
shift_age is documented as: Number of old log files to keep, or frequency of rotation (daily, weekly or monthly). Default value is 0.
shift_size is documented: Maximum logfile size in bytes (only applies when shift_age is a number). Defaults to 1048576 (1MB).
Given the above, a shift_age of 0 should prevent the retention of old log files, but maximum size (shift_size) should still be enforced.
But it's not: https://github.com/ruby/ruby/blob/master/lib/logger/log_device.rb#L124
So either the behavior or the documentation is wrong.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ruby-core:95873] [Ruby master Bug#16349] Logger shift_age of 0 disables shift_size
[not found] <redmine.issue-16349.20191115004819@ruby-lang.org>
2019-11-15 0:48 ` [ruby-core:95852] [Ruby master Bug#16349] Logger shift_age of 0 disables shift_size bughitgithub
2019-11-15 1:09 ` [ruby-core:95853] " hsbt
@ 2019-11-18 1:39 ` merch-redmine
2 siblings, 0 replies; 3+ messages in thread
From: merch-redmine @ 2019-11-18 1:39 UTC (permalink / raw
To: ruby-core
Issue #16349 has been updated by jeremyevans0 (Jeremy Evans).
I think this is a documentation bug, since the comment makes it explicit that shifting is always disabled if shift_age is 0. I submitted a pull request to update the documentation: https://github.com/ruby/logger/pull/43 .
----------------------------------------
Bug #16349: Logger shift_age of 0 disables shift_size
https://bugs.ruby-lang.org/issues/16349#change-82709
* Author: bughit (bug hit)
* Status: Assigned
* Priority: Normal
* Assignee: sonots (Naotoshi Seo)
* Target version:
* ruby -v:
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
shift_age is documented as: Number of old log files to keep, or frequency of rotation (daily, weekly or monthly). Default value is 0.
shift_size is documented: Maximum logfile size in bytes (only applies when shift_age is a number). Defaults to 1048576 (1MB).
Given the above, a shift_age of 0 should prevent the retention of old log files, but maximum size (shift_size) should still be enforced.
But it's not: https://github.com/ruby/ruby/blob/master/lib/logger/log_device.rb#L124
So either the behavior or the documentation is wrong.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-18 1:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <redmine.issue-16349.20191115004819@ruby-lang.org>
2019-11-15 0:48 ` [ruby-core:95852] [Ruby master Bug#16349] Logger shift_age of 0 disables shift_size bughitgithub
2019-11-15 1:09 ` [ruby-core:95853] " hsbt
2019-11-18 1:39 ` [ruby-core:95873] " merch-redmine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).