ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / Atom feed
From: naruse@airemix.jp
To: ruby-core@ruby-lang.org
Subject: [ruby-core:95770] [Ruby master Bug#16331] fails to build with BSD make when any -j option is given (including -j 1)
Date: Sat, 09 Nov 2019 10:14:02 +0000 (UTC)
Message-ID: <redmine.journal-82585.20191109101401.a04158d44f86f4b2@ruby-lang.org> (raw)
In-Reply-To: <redmine.issue-16331.20191107080425@ruby-lang.org>

Issue #16331 has been updated by naruse (Yui NARUSE).


meta@vmeta.jp (Koichiro Iwao) wrote:
> Now it turned out the build fails even `-j 1` is specified. Any value to `-j` option will fail.
> Not giving `-j` option goes fine.
> 
> Further information from Yuichiro NAITO:
> > 最初にレースコンディションと言っていたのは誤りで
> > -j の有無で shell に渡すコマンドの範囲が異なるのが原因でした。
> > 基本的にはビルド手順を1行づつ shell に渡すのが本来の make の実装なのですが、
> > BSD make は -j オプションをつけると、ビルド手順が複数行ある場合にまとめて shell に渡すようになります。
> > そうすると、途中で exec があった場合、残りのコマンドが実行されなくなります。
> > Ruby の Makefile では行の最後のコマンドに exec 使うことで、
> > 最後の fork(2) 実行を省略しようという意図のように見えます。
> > 
> > 結局のところ BSD make の互換性問題のように思います。

It sounds Ruby hits the issue described in `make -B`:
https://www.freebsd.org/cgi/man.cgi?query=make&apropos=0&sektion=0&manpath=FreeBSD+12.1-RELEASE+and+Ports&arch=default&format=html

----------------------------------------
Bug #16331: fails to build with BSD make when any -j option is given (including -j 1)
https://bugs.ruby-lang.org/issues/16331#change-82585

* Author: meta@vmeta.jp (Koichiro Iwao)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 2.6.5
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
When building Ruby parallely with BSD make (FreeBSD make), it fails to build.
Reported by FreeBSD Ruby folks. Please keep in mind I didn't find out the root cause.

OS: FreeBSD 12-STABLE
See also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241633

## How to reproduce
```
tar xf ruby-2.6.5.tar.gz
cd ruby-2.6.5
./configure --enable-shared --disable-readline --disable-libedit
make -j 8 # any value will cause build failure
(snip)
configuring -test-/st/numhash
configuring -test-/st/update
--- enc ---
ld: error: unable to find library -lruby
cc: error: linker command failed with exit code 1 (use -v to see invocation)
--- exts.mk ---
configuring -test-/string
configuring -test-/struct
configuring -test-/symbol
--- enc ---
*** [.ext/x86_64-freebsd12.1/enc/encdb.so] Error code 1
```

## BSD make without -j option: success
```
cd ruby-2.6.5
make distclean
./configure --enable-shared --disable-readline --disable-libedit
make
`ruby' is up to date.
*** Following extensions are not compiled:
readline:
	Could not be configured. It will not be installed.
	/home/sair/tmp/ruby-2.6.5/ext/readline/extconf.rb:52: readline not found
	Check ext/readline/mkmf.log for more details.
gdbm:
	Could not be configured. It will not be installed.
	Check ext/gdbm/mkmf.log for more details.
*** Fix the problems, then remove these directories and try again if you want.
making enc
making trans
`trans' is up to date.
making encs
Generating RDoc documentation
```

## Using GNU make: success

```
cd ruby-2.6.5
export MAKE=gmake # GNU make
make distclean
./configure --enable-shared --disable-readline --disable-libedit
$MAKE -j 8
```

---Files--------------------------------
ruby-bsdmake.log (13.9 KB)


-- 
https://bugs.ruby-lang.org/

  parent reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-16331.20191107080425@ruby-lang.org>
2019-11-07  8:04 ` [ruby-core:95741] [Ruby master Bug#16331] fails to build with BSD make possibly due to race condition meta
2019-11-08  3:31 ` [ruby-core:95752] " meta
2019-11-08  8:37 ` [ruby-core:95755] [Ruby master Bug#16331] fails to build with BSD make when any -j option is given (including -j 1) meta
2019-11-09 10:14 ` naruse [this message]
2019-11-10  0:27 ` [ruby-core:95771] " nobu

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-82585.20191109101401.a04158d44f86f4b2@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

ruby-core@ruby-lang.org archive (unofficial mirror)

Archives are clonable: git clone --mirror https://public-inbox.org/ruby-core

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.core
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.core
	nntp://news.gmane.org/gmane.comp.lang.ruby.core

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git