From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id B9F0D1F454 for ; Fri, 8 Nov 2019 18:09:44 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id ABE30120BC7; Sat, 9 Nov 2019 03:09:33 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 0AB1A120B76 for ; Sat, 9 Nov 2019 03:09:31 +0900 (JST) Received: by filter0090p3mdw1.sendgrid.net with SMTP id filter0090p3mdw1-24489-5DC5AF5F-6D 2019-11-08 18:09:35.910071274 +0000 UTC m=+75438.602808444 Received: from herokuapp.com (unknown [18.209.44.199]) by ismtpd0036p1iad1.sendgrid.net (SG) with ESMTP id ARiF1C-WTWOr-NYSSGjL9A for ; Fri, 08 Nov 2019 18:09:35.747 +0000 (UTC) Date: Fri, 08 Nov 2019 18:09:35 +0000 (UTC) From: jaruga@redhat.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 71388 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16234 X-Redmine-Issue-Author: jaruga X-Redmine-Sender: jaruga X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?yXpFNqRr1dEY0snEQ6vUpjORBmm3WV3CBkaa8tOjsKlz=2FSpsNNOw9kQ9BE+251?= =?us-ascii?Q?SkRx6ZUFDaZ5Sqs3D5asTdZCYkw4E8TBlfC=2FHeH?= =?us-ascii?Q?bqe0=2FAC27DMnrnaIKrg2JqRv9ejT1q7v19rD3d1?= =?us-ascii?Q?UMuPoRtP2Oj7Xif5GFdnJf6+PBGqtJ4hP1Y2xza?= =?us-ascii?Q?NGQixk3ujtp7WSjCcbT78TwLAq3BtHoTXFg=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 95763 Subject: [ruby-core:95763] [Ruby master Misc#16234] Enabling ARM 64/32-bit cases by Drone CI X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16234 has been updated by jaruga (Jun Aruga). > Some `.ext/common/*.rb` files are newer than `.ext/.timestamp/.RUBYCOMMONDIR.time` file. > That is the reason of the error. Sorry above is typo. To be correct, some `.ext/common/*.rb` files can be "older" than `.ext/.timestamp/.RUBYCOMMONDIR.time` file. That is the reason of the error. I investigated more about this. I might find the root cause of the error. First, `.ext/common/*.rb` and `ext/.timestamp/.RUBYCOMMONDIR.time` files are created by the command `$SETARCH make -s $JOBS`. I checked the behavior by `$SETARCH make --debug --trace V=1 $JOBS`. It runs `exts.mk` (maybe generated from `template/exts.mk.tmpl`?). And it executes `extensions` to build `ext/*/Makefile` in `exts.mk` in parallel with given `$JOBS`. The default value = -j3 for Travis x86_64, and -j33 for Travis arm64. Yes it is "-j33" on arm64. exts.mk ``` extensions = ext/psych/. ext/monitor/. ext/rbconfig/sizeof/. ext/pty/. \ ext/objspace/. ext/etc/. ext/openssl/. ext/ripper/. \ ... all static: ruby ... ruby: $(extensions:/.=/all) ``` Following each `Makefile` is executed in parallel without a exclusive lock. As a result, it seems `touch .RUBYCOMMONDIR.time` command is executed more than 2 times. `ext/*/Makefile` ``` $(TIMESTAMP_DIR)/.RUBYCOMMONDIR.time: $(Q) $(MAKEDIRS) $(@D) $(RUBYLIBDIR) $(Q) $(TOUCH) $@ ``` Following steps can happen. 1. `touch .ext/.timestamp/.RUBYCOMMONDIR.time` in `ext/foo/Makefile` 2. Create `.ext/common/foo.rb` in `ext/foo/Makefile` 3. `touch .ext/.timestamp/.RUBYCOMMONDIR.time` in `ext/bar/Makefile` 4. Create `.ext/common/bar.rb` in `ext/bar/Makefile` As a result, some `.ext/common/*.rb` files (In this case `.ext/common/foo.rb`) are older than `.ext/.timestamp/.RUBYCOMMONDIR.time` file. That is the reason of the error. ## Possible solution 1. Add an exclusive lock logic to `ext/*/Makefile` `$(TIMESTAMP_DIR)/.RUBYCOMMONDIR.time` task. 2. Run `ruby: $(extensions:/.=/all)` in `exts.mk` without parallel. But the performance is slower. Right now I am working to run with JOBS= (empty) for Travis arm64 case here. https://github.com/ruby/ruby/pull/2642 How do you think? I think the solution "1." is better, if we can implement it. ---------------------------------------- Misc #16234: Enabling ARM 64/32-bit cases by Drone CI https://bugs.ruby-lang.org/issues/16234#change-82580 * Author: jaruga (Jun Aruga) * Status: Closed * Priority: Normal * Assignee: ---------------------------------------- Currently ruby project has 4 CIs on GitHub. 1. Travis CI: linux cases with flags and compilers. 2. GitHub Actions: macros, windows, ubuntu 3. Wercker: Ruby JIT cases 4. Appveyor: windows I like to suggest 5th CI: Drone CI for ARM 64/32-bit cases. Drone CI supports native the ARM 64/32 bit environments. Have you used Drone CI? I tried to use both Drone CI and Shippable CI supporting ARM. My impression for Drone CI is quite good. Great user experience and user interface. Shippable CI was not so good for some reasons. Drone CI have not only linux ARM 64/32 bit environments on DockerRunner mode (= using container for CI like Wercker), but also freebsd, netbsd, openbsd, dragonfly (?) and solaris environments on ExecRunner (= maybe running commands directly without container) mode according to the following documents. * https://exec-runner.docs.drone.io/configuration/platform/ * https://docker-runner.docs.drone.io/configuration/platform/ Is it exciting isn't it? We can check ARM issue at a pull-request timing. Here is the example. The content is almost same with wercker.yml except JIT option. "ruby/3" is failed on the latest master branch, but "ruby/2" arm64 case is succeeded on old master branch. https://cloud.drone.io/junaruga/ruby/3 https://github.com/junaruga/ruby/blob/feature/ci-arm/.drone.yml https://cloud.drone.io/junaruga/ruby/2 Here is the pull-request as an example. https://github.com/ruby/ruby/pull/2520 .drone.yml is the file to manage the CI cases. But when you see most of the YAML parts between ARM 64-bit and 32-bit cases in .drone.yml is same. In case of .traivs.yml, we are using YAML anchor (&) and reference (*) feature effectively. But in case of .drone.yml I am not sure we can still use it beyond the "---" separator. Luckily Drone CI started providing the alternative .drone.star file by Starlark language. https://docs.drone.io/starlark/overview/ https://blog.drone.io/create-pipelines-using-starlark/ Enabling Drone CI is quite simple. Just go to https://drone.io/ , then register and enable target repository. UI is quite good. Pros * We can check ARM 64/32-bit cases, and possibly freebsd and solaris cases too. * It's for free. * Each developer can debug ARM cases on their forked repository. * Customize easily. I see .travis.yml is used effectively. Cons * Have to manage additonal file .drone.yml or .drone.star. But first, I want to ask you. Are you interested in using Drone CI for Ruby project? -- https://bugs.ruby-lang.org/