From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id A74BD1F4C0 for ; Tue, 29 Oct 2019 00:02:06 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 613AE1208FE; Tue, 29 Oct 2019 09:01:57 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 405AD1208FC for ; Tue, 29 Oct 2019 09:01:55 +0900 (JST) Received: by filter0081p3iad2.sendgrid.net with SMTP id filter0081p3iad2-5438-5DB78174-93 2019-10-29 00:01:56.598020517 +0000 UTC m=+3239.085482823 Received: from herokuapp.com (unknown [34.230.24.207]) by ismtpd0053p1iad1.sendgrid.net (SG) with ESMTP id -DoDiGbqRMWlU9TxQsH0dQ for ; Tue, 29 Oct 2019 00:01:56.518 +0000 (UTC) Date: Tue, 29 Oct 2019 00:01:56 +0000 (UTC) From: tenderlove@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 71170 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16282 X-Redmine-Issue-Author: tenderlovemaking X-Redmine-Sender: tenderlovemaking X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?lWh=2FbSnEjJFRTUHRj45oOQBme8zohdTU9K3TxrDAbWKGocbIJ2d7O=2F8uRkEXsK?= =?us-ascii?Q?a9gaJTj9tKy9dLrWQakYv8u7I7djwLrMr=2FgD8gN?= =?us-ascii?Q?+v+THNZL6AbFKDYRi8dvk=2FGHGOjp45HOr8yseiT?= =?us-ascii?Q?79aW3WiBYz5HsCgLJ9TyRAmme1fvPYq12gcHjBW?= =?us-ascii?Q?MTLfV8VPS7JKX4nbH75toSXvT4CsGQSMSUg=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 95577 Subject: [ruby-core:95577] [Ruby master Feature#16282] Add "call data" wrapper IMEMO object so inline cache can be updated X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16282 has been updated by tenderlovemaking (Aaron Patterson). Actually, I think this makes performance worse because it removes the "define". So there will be only one. I will fix it to maintain the macro. ---------------------------------------- Feature #16282: Add "call data" wrapper IMEMO object so inline cache can be updated https://bugs.ruby-lang.org/issues/16282#change-82360 * Author: tenderlovemaking (Aaron Patterson) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- Hi, Currently the compactor will invalidate all inline caches. I would like to update references in inline caches so we don't have to invalidate. Most inline caches are reachable from instruction sequences, but one cache is not: https://github.com/ruby/ruby/blob/6147fa82a923e7318f493857023006801ed25eb5/internal.h#L2395 This static variable can't be reached from the GC. I'd like to introduce a new IMEMO object that wraps this cache, then the GC can reach the cache and update the value. I've attached a patch that implements the new IMEMO object, and also removes the restriction on GCC so that all compilers get the cache hit. Does this seem OK shyouhei, ko1? ---Files-------------------------------- 0001-Wrap-call-data-with-an-IMEMO-object.patch (4.52 KB) -- https://bugs.ruby-lang.org/