From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 06B361F4C0 for ; Mon, 28 Oct 2019 13:00:16 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 7D122120969; Mon, 28 Oct 2019 21:59:57 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 68BCF120968 for ; Mon, 28 Oct 2019 21:59:54 +0900 (JST) Received: by filter0191p3mdw1.sendgrid.net with SMTP id filter0191p3mdw1-22299-5DB6E64E-3A 2019-10-28 12:59:58.500058965 +0000 UTC m=+569967.413857213 Received: from herokuapp.com (unknown [34.230.24.207]) by ismtpd0053p1mdw1.sendgrid.net (SG) with ESMTP id gL5CJSfXR-GxTezXtTRtfA for ; Mon, 28 Oct 2019 12:59:58.299 +0000 (UTC) Date: Mon, 28 Oct 2019 12:59:58 +0000 (UTC) From: jean.boussier@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 71168 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16029 X-Redmine-Issue-Author: byroot X-Redmine-Sender: byroot X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?AchqQMoUBMcQgz7gop0XiYUiatGIY7E61JGsTL4Fvjf6CcTdUZD1FE1hXyv7M1?= =?us-ascii?Q?8xfY76Sp4=2Fd+mRRJwXChoaKgHuMDBvVYAdk1Be+?= =?us-ascii?Q?gPR2XQ8NuUUU+ESWOelqLSeBBK36FOY6wOFiC3B?= =?us-ascii?Q?7ELiOfaBkIvqvEtH=2FU1fojYSY0WnxfaU7ALW4z6?= =?us-ascii?Q?oyEww5vEyt72dMFR1OYXAr0yOIWsUT8nemw=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 95575 Subject: [ruby-core:95575] [Ruby master Feature#16029] Expose fstring related APIs to C-extensions X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16029 has been updated by byroot (Jean Boussier). > What about rb_str_fstring_lookup and rb_str_fstring_lookup_enc? I don't think a lookup would be enough for what I'd like to do. A typical use case would be a JSON document with lots of duplicated strings. If we only lookup the `fstring` table, then only the strings already present in the codebase would be deduplicated. IMHO it would be much better to create them all as `fstrings`. ---------------------------------------- Feature #16029: Expose fstring related APIs to C-extensions https://bugs.ruby-lang.org/issues/16029#change-82357 * Author: byroot (Jean Boussier) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- As discussed with @tenderlove here: https://github.com/ruby/ruby/pull/2287#issuecomment-513865160 We'd like to update various data format parsers (JSON, MessagePack, etc) to add the possibility to deduplicate strings while parsing. But unfortunately the `rb_fstring_*` family of functions isn't available to C-extensions, so the only available fallback is `rb_funcall(str, rb_intern("-@"))` which most parsers will likely consider too slow. So the various `rb_fstring_*` functions would need to be public. Proposed patch: https://github.com/ruby/ruby/pull/2299 -- https://bugs.ruby-lang.org/