From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 836AE1F4C0 for ; Sun, 27 Oct 2019 22:38:57 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 2FC8E12098B; Mon, 28 Oct 2019 07:38:48 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 0558C12098A for ; Mon, 28 Oct 2019 07:38:45 +0900 (JST) Received: by filter0178p3mdw1.sendgrid.net with SMTP id filter0178p3mdw1-22447-5DB61C79-14 2019-10-27 22:38:49.250047196 +0000 UTC m=+518396.304342532 Received: from herokuapp.com (unknown [3.85.110.205]) by ismtpd0069p1mdw1.sendgrid.net (SG) with ESMTP id Rx1b2-YbQVyhn0N02hnQTw for ; Sun, 27 Oct 2019 22:38:49.135 +0000 (UTC) Date: Sun, 27 Oct 2019 22:38:49 +0000 (UTC) From: merch-redmine@jeremyevans.net Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 71166 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 14325 X-Redmine-Issue-Author: znz X-Redmine-Issue-Assignee: knu X-Redmine-Sender: jeremyevans0 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?RVE3t853K5scBhbmJHUzZTFFeVC=2FZSUmHZ0Dc+26wcEi2CTgsF1oz0wTSSxGGN?= =?us-ascii?Q?BI7DNCT9pEWcZh4jDLRubBeXYVMnjzZ1YSirMh4?= =?us-ascii?Q?wmoGzKAbiJdZ3X=2FsbK4IeOWJrU5Bz2Ex4IJAp=2F7?= =?us-ascii?Q?z5xpMRv1+ImNhxrVh3IUMbWG7DH1=2FLB5Aofkpor?= =?us-ascii?Q?Fjg6jBJwd+67nZ36Lx2oyg9lVTkWlx9xp4g=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 95573 Subject: [ruby-core:95573] [Ruby master Bug#14325] Set#reset raise RuntimeError instead of FrozenError X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #14325 has been updated by jeremyevans0 (Jeremy Evans). Status changed from Assigned to Closed Fixed in commit:afd68cd87114fb49158462f1594cacfd2b765e9b. ---------------------------------------- Bug #14325: Set#reset raise RuntimeError instead of FrozenError https://bugs.ruby-lang.org/issues/14325#change-82355 * Author: znz (Kazuhiro NISHIYAMA) * Status: Closed * Priority: Normal * Assignee: knu (Akinori MUSHA) * Target version: * ruby -v: ruby 2.6.0dev (2018-01-06 trunk 61640) [x86_64-darwin16] * Backport: 2.3: DONTNEED, 2.4: DONTNEED, 2.5: UNKNOWN ---------------------------------------- I think it should use `FrozenError` instead of `RuntimeError`. I can't reproduce without modifying instance variable directly. ``` % ruby -v -r set -e 'Set[].tap{|s|s.instance_variable_set(:@hash, :dummy)}.freeze.reset' ruby 2.6.0dev (2018-01-06 trunk 61640) [x86_64-darwin16] Traceback (most recent call last): 1: from -e:1:in `
' .../lib/ruby/2.6.0/set.rb:527:in `reset': can't modify frozen Set (RuntimeError) % ruby -v -I ./lib -r set -e 'Set[].tap{|s|s.instance_variable_set(:@hash, :dummy)}.freeze.reset' ruby 2.6.0dev (2018-01-06 trunk 61640) [x86_64-darwin16] Traceback (most recent call last): 1: from -e:1:in `
' .../lib/set.rb:527:in `reset': can't modify frozen Set (FrozenError) ``` ```patch diff --git a/lib/set.rb b/lib/set.rb index 9642e74af4..d777b81b8f 100644 --- a/lib/set.rb +++ b/lib/set.rb @@ -524,7 +524,7 @@ def reset if @hash.respond_to?(:rehash) @hash.rehash # This should perform frozenness check. else - raise "can't modify frozen #{self.class.name}" if frozen? + raise FrozenError, "can't modify frozen #{self.class.name}" if frozen? end self end ``` -- https://bugs.ruby-lang.org/