From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 287321F4C0 for ; Thu, 17 Oct 2019 05:55:31 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id DF747120AB7; Thu, 17 Oct 2019 14:55:21 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 2069F120AB5 for ; Thu, 17 Oct 2019 14:55:19 +0900 (JST) Received: by filter0125p3las1.sendgrid.net with SMTP id filter0125p3las1-24980-5DA80248-47 2019-10-17 05:55:20.972668776 +0000 UTC m=+630798.827765359 Received: from herokuapp.com (unknown [54.158.28.124]) by ismtpd0048p1iad2.sendgrid.net (SG) with ESMTP id Ihsup7C_TTKf_iNm3tV4Uw for ; Thu, 17 Oct 2019 05:55:20.827 +0000 (UTC) Date: Thu, 17 Oct 2019 05:55:21 +0000 (UTC) From: ko1@atdot.net Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 70970 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16029 X-Redmine-Issue-Author: byroot X-Redmine-Sender: ko1 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?fVTMYOBjtdvXNcWwrscBhLsHItUXVK5L4mtnq0mdcRdXAB+1l+GiVmjX9aYXeu?= =?us-ascii?Q?17Q3Qz1TU3HsVEFsxOAYyG=2FgrsnyFMJbLpaMV=2Fn?= =?us-ascii?Q?+XlD5ukF931tlqjmMNwn5pRiKGmxE=2FJ8kNKOk5k?= =?us-ascii?Q?iac4TjjSqNkeY=2FhmHZwUw7NpzOTbDA7F404e1uB?= =?us-ascii?Q?nAVl2gShR=2FkoX?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 95381 Subject: [ruby-core:95381] [Ruby master Feature#16029] Expose fstring related APIs to C-extensions X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16029 has been updated by ko1 (Koichi Sasada). Hi. (1) implementation Current implementation can have issue (related to shared string) and this issue can cause something wrong behavior for C-extension. Sorry, we need a time to confirm. (2) naming i think it should be `rb_str_...` prefix. ---------------------------------------- Feature #16029: Expose fstring related APIs to C-extensions https://bugs.ruby-lang.org/issues/16029#change-82092 * Author: byroot (Jean Boussier) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- As discussed with @tenderlove here: https://github.com/ruby/ruby/pull/2287#issuecomment-513865160 We'd like to update various data format parsers (JSON, MessagePack, etc) to add the possibility to deduplicate strings while parsing. But unfortunately the `rb_fstring_*` family of functions isn't available to C-extensions, so the only available fallback is `rb_funcall(str, rb_intern("-@"))` which most parsers will likely consider too slow. So the various `rb_fstring_*` functions would need to be public. Proposed patch: https://github.com/ruby/ruby/pull/2299 -- https://bugs.ruby-lang.org/