From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.7 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 36CFF1F4C0 for ; Mon, 14 Oct 2019 05:22:25 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id D7D17120905; Mon, 14 Oct 2019 14:22:16 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 4BE57120902 for ; Mon, 14 Oct 2019 14:22:14 +0900 (JST) Received: by filter0134p3las1.sendgrid.net with SMTP id filter0134p3las1-15340-5DA40607-3B 2019-10-14 05:22:15.884668574 +0000 UTC m=+369336.107903244 Received: from herokuapp.com (unknown [54.146.158.196]) by ismtpd0094p1iad2.sendgrid.net (SG) with ESMTP id 4DBrEpmyRCuiXR8MjTDHBQ for ; Mon, 14 Oct 2019 05:22:15.647 +0000 (UTC) Date: Mon, 14 Oct 2019 05:22:15 +0000 (UTC) From: sam.saffron@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 70904 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16029 X-Redmine-Issue-Author: byroot X-Redmine-Sender: sam.saffron X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?GD31AXMrLYtZC3ZmvheLkg5nAqKYtjT=2Fa5aksj98ZWPgCOwFCNgaD8GubLcxM9?= =?us-ascii?Q?K6DFGbyZOw8ZlSg5sNTsXr9HN+6HcXTfIdPAMz0?= =?us-ascii?Q?K=2F+MrrRd0YpcMml6gim80jEvn8D1c7Ext0lV55m?= =?us-ascii?Q?FScJKyZoEmESwtGXfxx07e+aTBRvaztPrwZbB7B?= =?us-ascii?Q?6A+nclL3NyZKJJjj=2FKCA6AoioRuSPjv4I1w=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 95316 Subject: [ruby-core:95316] [Ruby master Feature#16029] Expose fstring related APIs to C-extensions X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16029 has been updated by sam.saffron (Sam Saffron). I was thinking something like? ``` VALUE rb_fstring_lookup(char *ptr, rb_encoding *enc) { st_data_t fstring; struct RString fake_str; setup_fake_str(&fake_str, ptr, len, ENCINDEX_US_ASCII) st_table *frozen_strings = rb_vm_fstring_table(); if (!st_lookup(frozen_strings, (st_data_t)fake_str, &fstring)) { return Qnil; } return ret; } ``` ---------------------------------------- Feature #16029: Expose fstring related APIs to C-extensions https://bugs.ruby-lang.org/issues/16029#change-82018 * Author: byroot (Jean Boussier) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- As discussed with @tenderlove here: https://github.com/ruby/ruby/pull/2287#issuecomment-513865160 We'd like to update various data format parsers (JSON, MessagePack, etc) to add the possibility to deduplicate strings while parsing. But unfortunately the `rb_fstring_*` family of functions isn't available to C-extensions, so the only available fallback is `rb_funcall(str, rb_intern("-@"))` which most parsers will likely consider too slow. So the various `rb_fstring_*` functions would need to be public. Proposed patch: https://github.com/ruby/ruby/pull/2299 -- https://bugs.ruby-lang.org/