ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: jean.boussier@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:95276] [Ruby master Feature#16029] Expose fstring related APIs to C-extensions
Date: Tue, 08 Oct 2019 11:07:50 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-81952.20191008110749.b14e8a0c16e0b965@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-16029.20190731010619@ruby-lang.org

Issue #16029 has been updated by byroot (Jean Boussier).


@sam.saffron Unless I'm missing something, that's exactly what `rb_fstring_new / rb_fstring_cstr` does.

```
VALUE rb_fstring_new(const char *ptr, long len);
VALUE rb_fstring_cstr(const char *str);
```

AFAICT It does allocate an RVALUE to lookup the table, but it does it on the stack, so I think it's fine GC wise.

----------------------------------------
Feature #16029: Expose fstring related APIs to C-extensions
https://bugs.ruby-lang.org/issues/16029#change-81952

* Author: byroot (Jean Boussier)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
As discussed with @tenderlove here: https://github.com/ruby/ruby/pull/2287#issuecomment-513865160

We'd like to update various data format parsers (JSON, MessagePack, etc) to add the possibility to deduplicate strings while parsing.

But unfortunately the `rb_fstring_*` family of functions isn't available to C-extensions, so the only available fallback is `rb_funcall(str, rb_intern("-@"))` which most parsers will likely consider too slow. So the various `rb_fstring_*` functions would need to be public.

Proposed patch: https://github.com/ruby/ruby/pull/2299



-- 
https://bugs.ruby-lang.org/

  parent reply	other threads:[~2019-10-08 11:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-16029.20190731010619@ruby-lang.org>
2019-07-31  1:06 ` [ruby-core:94064] [Ruby master Feature#16029] Expose fstring related APIs to C-extensions jean.boussier
2019-09-03 15:32 ` [ruby-core:94761] " jean.boussier
2019-09-03 16:42 ` [ruby-core:94763] " mame
2019-10-07 22:25 ` [ruby-core:95269] " sam.saffron
2019-10-08 11:07 ` jean.boussier [this message]
2019-10-08 23:34 ` [ruby-core:95285] " sam.saffron
2019-10-14  5:22 ` [ruby-core:95316] " sam.saffron
2019-10-17  5:55 ` [ruby-core:95381] " ko1
2019-10-17 21:09 ` [ruby-core:95403] " sam.saffron
2019-10-28 12:59 ` [ruby-core:95575] " jean.boussier
2019-12-31  6:46 ` [ruby-core:96607] " sam.saffron
2020-01-01 11:05 ` [ruby-core:96613] " jean.boussier
2020-01-05  0:58 ` [ruby-core:96666] " sam.saffron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-81952.20191008110749.b14e8a0c16e0b965@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).