From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 0CE821F4BD for ; Fri, 4 Oct 2019 11:07:21 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 6E663120AA3; Fri, 4 Oct 2019 20:06:58 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id AB5D5120AA0 for ; Fri, 4 Oct 2019 20:06:55 +0900 (JST) Received: by filter0095p3las1.sendgrid.net with SMTP id filter0095p3las1-5336-5D9727D0-8B 2019-10-04 11:06:56.904037281 +0000 UTC m=+59338.728714509 Received: from herokuapp.com (unknown [18.212.244.163]) by ismtpd0063p1iad2.sendgrid.net (SG) with ESMTP id gQcg_XcnQjSgsGDaBv782Q for ; Fri, 04 Oct 2019 11:06:56.713 +0000 (UTC) Date: Fri, 04 Oct 2019 11:06:56 +0000 (UTC) From: gabrielnagy@me.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 70804 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16233 X-Redmine-Issue-Author: gabuscus X-Redmine-Sender: gabuscus X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?sQwgSOMP1xrdgw5pnJic3oCvIucOMRoqqWZbOdJHFhqHVhh7Sw9nhbMASd6WaO?= =?us-ascii?Q?nC19SbzFsocMrIO1wgfVlUkloWntNqh00Sz+B6k?= =?us-ascii?Q?i3XBBmriLSpz9B+m601miaMlJKWJ8sugF80caAF?= =?us-ascii?Q?A+odUYfswOIVKJw7YsYRe2=2FwJUiashRW4kKDdFd?= =?us-ascii?Q?K+J0PLxL0zGj1nunmg4DcMipplADxda3aSg=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 95217 Subject: [ruby-core:95217] [Ruby master Bug#16233] winruby UTF8 Fallback for no CodePage X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16233 has been updated by gabuscus (Gabriel Nagy). duerst (Martin D=FCrst) wrote: > If codepage 720 is not supported, then we should look at supporting it. fair point, however investigation on this Puppet ticket: https://tickets.pu= ppetlabs.com/browse/PA-2191 concluded that falling back to UTF-8 fixes the = issue (for codepage 720 at least). we could also check the codepage when ca= tching the ArgumentError so we fallback only in that case ---------------------------------------- Bug #16233: winruby UTF8 Fallback for no CodePage https://bugs.ruby-lang.org/issues/16233#change-81890 * Author: gabuscus (Gabriel Nagy) * Status: Open * Priority: Normal * Assignee: = * Target version: = * ruby -v: 2.6.3 * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN ---------------------------------------- This is to deal specifically with setting the Region to Arabic which sets the codepage to 720. This codepage isn't recognised by Ruby which causes it to fail during initialisation when setting up LOCALE. This patch to Ruby is necessary to handle languages/regions on windows where the codepage is not supported by Ruby such as Arabic which uses = codepage 720. If the codepage is not found, the Locale falls back to UTF8. This is a well known Ruby/Ruby on Rails issue which is described at https://stackoverflow.com/questions/22815542/rails4-unknown-encoding-name-c= p720 Opened PR: https://github.com/ruby/ruby/pull/2518 ---Files-------------------------------- windows_nocodepage_utf8_fallback_r2.5.patch (946 Bytes) -- = https://bugs.ruby-lang.org/ Unsubscribe: