From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_YAHOO_RCVD,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id D5E341F4BE for ; Fri, 4 Oct 2019 00:58:39 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id EF5651209F8; Fri, 4 Oct 2019 09:58:29 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 6FD831209D9 for ; Fri, 4 Oct 2019 09:58:27 +0900 (JST) Received: by filter0161p3mdw1.sendgrid.net with SMTP id filter0161p3mdw1-28300-5D969935-41 2019-10-04 00:58:29.566668261 +0000 UTC m=+23253.860617470 Received: from herokuapp.com (unknown [54.87.117.53]) by ismtpd0035p1mdw1.sendgrid.net (SG) with ESMTP id Z5HSlXfGTDu8Hlil34SdAA for ; Fri, 04 Oct 2019 00:58:29.585 +0000 (UTC) Date: Fri, 04 Oct 2019 00:58:29 +0000 (UTC) From: burdettelamar@yahoo.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 70801 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16235 X-Redmine-Issue-Author: burdettelamar@yahoo.com X-Redmine-Sender: burdettelamar@yahoo.com X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?M0WX68AHQr=2FVSnvsB1Qo5xEo9+xKABJC=2FqJZ83MVt=2FoZaDNxJ1xO99UJJkfCtX?= =?us-ascii?Q?3QW0FV0DBHBTbZ0LbEx0D6ur+4ojDE1eP=2FTcW+E?= =?us-ascii?Q?ZmsrBsBtt8lTVwaf5uUCOxg8sEuQwtvGJ6SGLuw?= =?us-ascii?Q?IZ2PU4=2FcoYh2zCZj6hOjwjydx7pZzxgq5U98sPp?= =?us-ascii?Q?W1JP=2FgXwczZl3hUdPhlY0TsbEHCv6IhCzRw=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 95214 Subject: [ruby-core:95214] [Ruby master Misc#16235] ENV.assoc spec test does not test invalid name X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16235 has been updated by burdettelamar@yahoo.com (Burdette Lamar). Got it, thanks. Will update the diff. ---------------------------------------- Misc #16235: ENV.assoc spec test does not test invalid name https://bugs.ruby-lang.org/issues/16235#change-81888 * Author: burdettelamar@yahoo.com (Burdette Lamar) * Status: Open * Priority: Normal * Assignee: ---------------------------------------- The most important thing here is an added test for an invalid name argument to ENV.assoc, which should raise TypeError. I've also added to spec_helper.rb: - Methods :reserve_names and :release_names, to reserve and release names used in the test. - Method :mock_to_str, to return a mock object that responds to :to_str. The updated assoc_spec.rb uses all of these, as will many other spec tests for ENV, as I get to them. It's known that some of the ENV spec tests do not test a method's return value, and that some do not test error conditions (as above), so more to come. All in good time. ---Files-------------------------------- t.diff (2.24 KB) -- https://bugs.ruby-lang.org/