[ruby-core:95210] [Ruby master Misc#16235] ENV.assoc spec test does not test invalid name

[merch-redmine@jeremyevans.net]

Issue #16235 has been updated by jeremyevans0 (Jeremy Evans).


burdettelamar@yahoo.com (Burdette Lamar) wrote:
> Method :reserve_names fails if any name is already in use:
> 
> ```
> def reserve_names(*names)
>   @reserved = names
>   @reserved.each  do |name|
>     fail "Name #{name} is already in use" if ENV.include?(name)
>   end
> end
> ```
> 
> So, not a problem?

`reserve_names` is called in a `before :each` block.  When it fails, the `after :each` block is called.  That block calls `release_names` which will delete the entry from the environment. In my opinion, if you are checking whether the environment variable is already set, and it is already set, and the spec fails because of this, you probably should not remove the entry from the environment.  Otherwise you are making the spec fail for no reason.

----------------------------------------
Misc #16235: ENV.assoc spec test does not test invalid name
https://bugs.ruby-lang.org/issues/16235#change-81884

* Author: burdettelamar@yahoo.com (Burdette Lamar)
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
The most important thing here is an added test for an invalid name argument to ENV.assoc, which should raise TypeError.

I've also added to spec_helper.rb:

- Methods :reserve_names and :release_names, to reserve and release names used in the test.
- Method :mock_to_str, to return a mock object that responds to :to_str.

The updated assoc_spec.rb uses all of these, as will many other spec tests for ENV, as I get to them.

It's known that some of the ENV spec tests do not test a method's return value, and that some do not test error conditions (as above), so more to come.  All in good time.

---Files--------------------------------
t.diff (2.24 KB)


-- 
https://bugs.ruby-lang.org/