ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: keystonelemur@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:95180] [Ruby master Feature#16182] Should `expr in a, b, c` be allowed or not?
Date: Wed, 02 Oct 2019 03:24:51 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-81813.20191002032450.d0a03b6a07af4970@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-16182.20190926080401@ruby-lang.org

Issue #16182 has been updated by baweaver (Brandon Weaver).


I wonder if it would make sense to reverse this to be left-to-right (LTR) rather than right-to-left (RTL) to make it easier to parse.

I cannot think of another RTL syntax in Ruby at the moment, including the current `for ... in` statement:

```
for item in collection
```

A full example might be:

```
for a, b in { a: 1, b: 2 }
  p a, b
end
:a
1
:b
2
=> {:a=>1, :b=>2}
```

Of course this does not currently work with keyword arguments:

```
[2] pry(main)> for a: 1, b: 2 in [{ a: 1 }, { b: 2 }]
SyntaxError: unexpected ':', expecting '.' or &. or :: or '['
for a: 1, b: 2 in [{ a: 1 }, { b: 2...
     ^
[2] pry(main)> for a:, b: in [{ a: 1 }, { b: 2 }]
SyntaxError: unexpected tSYMBEG, expecting do or '{' or '('
for a:, b: in [{ a: 1 }, { b: 2 }]
```

What if we leveraged some of the current logic for parsing a `for ... in` statement to make single-line pattern matching into a LTR syntax? This may be a solution for the parsing difficulties, as well as build on the intuition of Ruby developers expecting LTR syntaxes naturally.

----------------------------------------
Feature #16182: Should `expr in a, b, c` be allowed or not?
https://bugs.ruby-lang.org/issues/16182#change-81813

* Author: mame (Yusuke Endoh)
* Status: Open
* Priority: Normal
* Assignee: matz (Yukihiro Matsumoto)
* Target version: 
----------------------------------------
In #15865, a new syntax `<expr> in <pattern>` was introduced.  By using this, we can write:

```
json = { foo: 1, bar: 2}

if json in { foo:, bar: }
  p [foo, bar] #=> [1, 2]
end
```

However, we cannot write:

```
p(json in { foo:, bar: }) #=> expected: true, actual: syntax error
```

This is because `<expr> in <pattern>` is an expression but not an argument.  For example, `foo(json in a, b, c)` is ambiguous: it is considered `foo((json in a), b, c)` and `foo((json in a, b, c))`.

What should we do?

1. Do nothing; we admit that it is a spec
2. Revert the feature
3. Disallow a pattern like `a, b, c` or `a:, b:, c:` in this one-line pattern matching syntax; we ask a user to write `json in [a, b, c]` or `json in {a:, b:, c:}`



-- 
https://bugs.ruby-lang.org/

  parent reply	other threads:[~2019-10-02  3:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-16182.20190926080401@ruby-lang.org>
2019-09-26  8:04 ` [ruby-core:95098] [Ruby master Feature#16182] Should `expr in a, b, c` be allowed or not? mame
2019-10-01 13:36 ` [ruby-core:95171] " shevegen
2019-10-02  3:24 ` keystonelemur [this message]
2019-10-02  8:05 ` [ruby-core:95185] " matz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-81813.20191002032450.d0a03b6a07af4970@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).