ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: shevegen@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:95163] [Ruby master Misc#16192] ENV.update hash values ignored when block given
Date: Mon, 30 Sep 2019 23:18:28 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-81800.20190930231827.844a5a34d38e07f9@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-16192.20190930221227@ruby-lang.org

Issue #16192 has been updated by shevegen (Robert A. Heiler).


I can not say whether it is a bug or not, but I believe that either way,
it would be good to mention, in the documentation, which behaviour is to
be expected e. g. for the example you gave:

    ENV.update('foo' => 'value_from_hash') { |name, old, new| 'value_from_block' }

If I understood the behaviour correctly then the block has a higher priority than
the (first) argument to .update(). Again, no idea if this is a bug or the
desired behaviour, but I think it would help if the documentation could
specify this and perhaps add a few examples to quickly demonstrate the use of
the method.

(Here is the link I used, if anyone else wants to look at it quickly: 
https://ruby-doc.org/core-2.6.4/ENV.html#method-c-update )

----------------------------------------
Misc #16192: ENV.update hash values ignored when block given
https://bugs.ruby-lang.org/issues/16192#change-81800

* Author: burdettelamar@yahoo.com (Burdette Lamar)
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
Doc:

update(hash) → Hash
update(hash) { |name, old_value, new_value| block } → Hash

Adds the contents of hash to the environment variables. If no block is specified entries with duplicate keys are overwritten, otherwise the value of each duplicate name is determined by calling the block with the key, its value from the environment and its value from the hash.

But:

The attached code shows that the block is called and its returned value assigned even if the name is not a duplicate.  So basically this means that when a block is given, the hash values are ignored for all keys.

I had expected that for a non-duplicate name, the block would be ignored, and the hash value assigned.

I'm calling this a Misc, and not a Bug, just in case I'm missing something.

---Files--------------------------------
t.rb (179 Bytes)


-- 
https://bugs.ruby-lang.org/

  parent reply	other threads:[~2019-09-30 23:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-16192.20190930221227@ruby-lang.org>
2019-09-30 22:12 ` [ruby-core:95161] [Ruby master Misc#16192] ENV.update hash values ignored when block given burdettelamar
2019-09-30 23:18 ` shevegen [this message]
2019-10-01  3:24 ` [ruby-core:95165] " nobu
2019-11-30 17:18 ` [ruby-core:96038] [Ruby master Bug#16192] " eregontp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-81800.20190930231827.844a5a34d38e07f9@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).