From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id B07A91F463 for ; Mon, 23 Sep 2019 00:25:36 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 6B2B9120AE9; Mon, 23 Sep 2019 09:25:28 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id BE0C31209A5 for ; Mon, 23 Sep 2019 09:25:25 +0900 (JST) Received: by filter0042p3iad2.sendgrid.net with SMTP id filter0042p3iad2-19667-5D8810F7-3 2019-09-23 00:25:27.077956021 +0000 UTC m=+284444.406010771 Received: from herokuapp.com (unknown [54.224.117.74]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id I3ovwrCoT3OzBKm6YCjCyg for ; Mon, 23 Sep 2019 00:25:26.969 +0000 (UTC) Date: Mon, 23 Sep 2019 00:25:27 +0000 (UTC) From: XrXr@users.noreply.github.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 70595 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16151 X-Redmine-Issue-Author: alanwu X-Redmine-Sender: alanwu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?PWg67P6owy8ojUUZg1G=2FQM4Z0jTQ2XLCqLM8Y2L8tUvRFuUPM6+aKANjRFY5CJ?= =?us-ascii?Q?rI0JhebTuADNthQFVLGw71B2xOn3NPbHMTsxZPh?= =?us-ascii?Q?V4p2NhXyYtVQFEp=2FES8xE7MFW3EEWc6WkbFG14x?= =?us-ascii?Q?2ofCaGrLJPA3fpaLlCK1aTDpNNJVepC42prlTJI?= =?us-ascii?Q?NsXgbv5Gx4IeKX+5LLzeH8NTqqLB0S4WYXA=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 95040 Subject: [ruby-core:95040] [Ruby master Bug#16151] [PATCH] Fix a class of fstring related use-after-free X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16151 has been updated by alanwu (Alan Wu). I ran some quick tests on rejecting frozen non-bare strings from the buffer deduplication code path. On Discourse, about 18% of calls to rb_fstring are refused with the change in https://bugs.ruby-lang.org/issues/16151#note-5. So I don't think that's a viable approach. I've put together a PR with nobu's idea, using a new flag to make sure to not defeat the optimization in #13085. I also took the liberty to rename STR_IS_SHARED_M since it's a little confusing to have this many things talk about sharing. https://github.com/ruby/ruby/pull/2480 ---------------------------------------- Bug #16151: [PATCH] Fix a class of fstring related use-after-free https://bugs.ruby-lang.org/issues/16151#change-81671 * Author: alanwu (Alan Wu) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.7.0dev (2019-09-07T18:26:35Z master e9bc8b35c6) [x86_64-linux] * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN ---------------------------------------- Pull request: https://github.com/ruby/ruby/pull/2435 ## The bug Run the following against master(e9bc8b3) to observe use-after-free: ```ruby -('a' * 30).force_encoding(Encoding::ASCII) a = ('a' * 30).force_encoding(Encoding::ASCII).taint t = Thread.new{} t.name = a eval('', binding, t.name) p a ``` ```ruby -('a' * 30).force_encoding(Encoding::ASCII) a = ('a' * 30).force_encoding(Encoding::ASCII).taint require 'ripper' ripper = Ripper.new("", a) eval('', binding, ripper.filename) p a ``` There may be other cases in the standard library or in the wild. ## Background When a string has both `STR_NOEMBED` and `STR_SHARED` set, it relies on a different string for its buffer. I will refer to strings that are depended upon as "shared roots". Shared roots are frozen and have the `STR_SHARED` unset. This is a bit unintuitive to me. A name for `STR_SHARED` that makes more sense to me would be `STR_BUFFER_ELSEWHERE`. ## What went wrong It is not safe to free the buffer of a shared root while it has dependants. The root and its dependants use the same buffer. As such, it is only safe to free the shared buffer when all users are unreachable on the heap. ## The Fix `rb_fstring` has a code path that frees and replaces the buffer of its input. Using this code path on the shared root of dependant strings sets up use-after-free. This patch removes the problematic code path as no tests require said buffer replacement functionality. Additionally, there has been three other issues that steam from this particular code path. See #15926, #15916 and #16136 --- I used @mame's commit in #16136 as the starting point for this investigation. Thank you! -- https://bugs.ruby-lang.org/