From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.8 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 5EC781F464 for ; Sun, 22 Sep 2019 18:40:29 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 0639B12099B; Mon, 23 Sep 2019 03:40:20 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id B0A731208CE for ; Mon, 23 Sep 2019 03:40:17 +0900 (JST) Received: by filter0031p3iad2.sendgrid.net with SMTP id filter0031p3iad2-27549-5D87C011-33 2019-09-22 18:40:17.519998747 +0000 UTC m=+263988.593398635 Received: from herokuapp.com (unknown [54.224.117.74]) by ismtpd0024p1mdw1.sendgrid.net (SG) with ESMTP id lpMzEdEVRyGdzly_M1DjpA for ; Sun, 22 Sep 2019 18:40:17.376 +0000 (UTC) Date: Sun, 22 Sep 2019 18:40:17 +0000 (UTC) From: eregontp@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 70593 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16173 X-Redmine-Issue-Author: burdettelamar@yahoo.com X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?KippOI8ZHtTweq7XfQzW93937kJ4QNWwSBuHnaMEcr2lvi63xEkaVC6522wI1v?= =?us-ascii?Q?xWqjrSyqkZQpchmht3OKuA8lE1Apwk+RiqGG98m?= =?us-ascii?Q?PWZyEz9hPsRZTBn1pIBeWXmdbsJkQbdCyQ99596?= =?us-ascii?Q?znstiQ8OF4Rn=2FlHjAv0ofa2X3XpGsxuf2pTW4tj?= =?us-ascii?Q?jTxAIu2Rh4mIv2l6ZAPNvPzWXEwPvDu0qIg=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 95038 Subject: [ruby-core:95038] [Ruby master Bug#16173] ENV.delete returns nil when name does not exist and block given X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16173 has been updated by Eregon (Benoit Daloze). IMHO it's better to fix behavior to be consistent with Hash#delete. And the compatibility risk seems non existent here. So I think we should change behavior, and not change documentation which would be inconsistent with Hash#delete. +1 for @nobu's patch. ---------------------------------------- Bug #16173: ENV.delete returns nil when name does not exist and block given https://bugs.ruby-lang.org/issues/16173#change-81669 * Author: burdettelamar@yahoo.com (Burdette Lamar) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.6.4p104 (2019-08-28 revision 67798) [x64-mingw32] * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN ---------------------------------------- Attached diff.txt: * ENV.delete for nonexistent name and block given: * Test enhanced to verify return value is nil. * Documentation corrected to say that return value is nil, not value. ---Files-------------------------------- diff.txt (2.22 KB) -- https://bugs.ruby-lang.org/