From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.8 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 609BA1F461 for ; Mon, 9 Sep 2019 09:40:44 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 0D38A1209D8; Mon, 9 Sep 2019 18:40:37 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 760F11209B5 for ; Mon, 9 Sep 2019 18:40:34 +0900 (JST) Received: by filter0101p3las1.sendgrid.net with SMTP id filter0101p3las1-8309-5D761E14-10 2019-09-09 09:40:36.238915291 +0000 UTC m=+493994.740441932 Received: from herokuapp.com (unknown [3.86.63.147]) by ismtpd0042p1mdw1.sendgrid.net (SG) with ESMTP id hOOGvifgSymIa45DcEqfgg for ; Mon, 09 Sep 2019 09:40:36.027 +0000 (UTC) Date: Mon, 09 Sep 2019 09:40:36 +0000 (UTC) From: shevegen@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 70412 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16155 X-Redmine-Issue-Author: connorshea X-Redmine-Sender: shevegen X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?6lbdtOg4RDRLuxD00eQtQKgoNAsge5d4xND7cbMQd0yDrCJ1cd8wGJ0a3WLPdW?= =?us-ascii?Q?8652ldFrr=2F4SQNr=2Fat6D+YOWiOUDpQ53sxvZVma?= =?us-ascii?Q?G7m2aEESh9c5cZs813X4St1fJDVbuuKuR3EqpFx?= =?us-ascii?Q?XmNPbtKZvnS9WR2plVOOT1cil7ElTaSyl1ISGaW?= =?us-ascii?Q?pr2RUWUQg0Jo7EG6HOgpLJ9pvNHk6=2FQ+60g=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 94857 Subject: [ruby-core:94857] [Ruby master Feature#16155] Add an Array#intersection method X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16155 has been updated by shevegen (Robert A. Heiler). I sort of agree with your reasoning. A slight add-on, though, on that part: > This would essentially just be a more readable alias for Array#& It is probably easier to search for it (e. g. a google-search for .intersection) than for &. But if we compare relative merits then we also have to remember an advantage for & being that it is short/succinct. It's an aside, though, because I agree with your reasoning anyway; it would make sense to also have .intersection, IMO. :) You could consider adding this to the upcoming developer meeting: https://bugs.ruby-lang.org/issues/16152 And ask matz whether he would be fine with the functionality itself; or, more importantly, the name for the method (#intersection) since the functionality already exists. ---------------------------------------- Feature #16155: Add an Array#intersection method https://bugs.ruby-lang.org/issues/16155#change-81478 * Author: connorshea (Connor Shea) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- `Array#union` and `Array#difference` were added in Ruby 2.6 ([see this bug](https://bugs.ruby-lang.org/issues/14097)), but an equivalent for `&` (intersection) was not. I'd like to propose `Array#intersection`. This would essentially just be a more readable alias for `Array#&`, in the same way that `Array#|` and `Array#-` have `Array#union` and `Array#difference`. I think it'd make sense for Ruby to have a more readable name for this method :) Current syntax: ``` ruby [ 1, 1, 3, 5 ] & [ 3, 2, 1 ] #=> [ 1, 3 ] [ 'a', 'b', 'b', 'z' ] & [ 'a', 'b', 'c' ] #=> [ 'a', 'b' ] ``` What I'd like to see added: ```ruby [ 1, 1, 3, 5 ].intersection([ 3, 2, 1 ]) #=> [ 1, 3 ] [ 'a', 'b', 'b', 'z' ].intersection([ 'a', 'b', 'c' ]) #=> [ 'a', 'b' ] ``` mame asks about `intersection` [in this comment](https://bugs.ruby-lang.org/issues/14097#note-26) on the `union`/`difference` bug, but as far as I can tell it was never addressed. [`Set#intersection`](http://ruby-doc.org/stdlib-2.6.2/libdoc/set/rdoc/Set.html#method-i-intersection) already exists and is an alias for `Set#&`, so there's precedent for such a method to exist. Thanks for Ruby, I enjoy using it a lot! :) Related links: - [PR for `union`](https://github.com/ruby/ruby/pull/1747) - [PR for `difference`](https://github.com/ruby/ruby/pull/1758) - [Bug for adding `union` and `difference` methods](https://bugs.ruby-lang.org/issues/14097) -- https://bugs.ruby-lang.org/