From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id C84721F461 for ; Sat, 7 Sep 2019 04:48:51 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id ACFB61209FB; Sat, 7 Sep 2019 13:48:41 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (unknown [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id AB1421209FB for ; Sat, 7 Sep 2019 13:48:38 +0900 (JST) Received: by filter0104p3las1.sendgrid.net with SMTP id filter0104p3las1-7557-5D7336A5-E 2019-09-07 04:48:37.436335761 +0000 UTC m=+303136.372561138 Received: from herokuapp.com (unknown [54.80.245.30]) by ismtpd0017p1iad2.sendgrid.net (SG) with ESMTP id e2n5rXb6TIaPWRnFKEwWjg for ; Sat, 07 Sep 2019 04:48:37.206 +0000 (UTC) Date: Sat, 07 Sep 2019 04:48:37 +0000 (UTC) From: mame@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 70369 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16136 X-Redmine-Issue-Author: deivid X-Redmine-Sender: mame X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?EJh2gqwnyqXtd++xo=2FinyA1V0bXouTB4FkWnzNiKb49s8zdRpllBFY0EokWGQe?= =?us-ascii?Q?Ppzatj6+RcXVAs4OZWzJD0LPIj8yH=2FWldIGWELe?= =?us-ascii?Q?Hc98opQ2I14Sc7ubAnkJ0IdWEwZK+MPMQbhFEJF?= =?us-ascii?Q?q8dy2zyBO7IO7M7+=2FPe0FHQwehxox6rDIcsRZX3?= =?us-ascii?Q?FP3bjZv4r4L63+UtxWfhqbFS3nM6sCfi9yQ=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 94814 Subject: [ruby-core:94814] [Ruby master Bug#16136] String corruption in 2.6.4 X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16136 has been updated by mame (Yusuke Endoh). @vcsjones Good to hear! Thank you for confirming. And your investigation = by bisect was very helpful. @deivid The most difficult part for me was to read .circleci/config.yml to = reproduce the issue on my machine :-) ---------------------------------------- Bug #16136: String corruption in 2.6.4 https://bugs.ruby-lang.org/issues/16136#change-81435 * Author: deivid (David Rodr=EDguez) * Status: Closed * Priority: Normal * Assignee: = * Target version: = * ruby -v: ruby 2.6.4p104 (2019-08-28 revision 67798) [x86_64-linux] * Backport: 2.5: DONTNEED, 2.6: REQUIRED ---------------------------------------- When trying to upgrade activeadmin's tests to use ruby 2.6.4, I got some ve= ry weird failures where some strings would end up containing random content= . See https://circleci.com/gh/activeadmin/activeadmin/20329 for an example = of those failures. Failures are somewhat random but the test suite seems to= consistently fail on 2.6.4 and pass on 2.6.3. I also managed to reproduce = the failures locally, sometimes very consistently, but now it's hardly ever= happening... :/ I looked at the changes in 2.6.4 and it looks like https://bugs.ruby-lang.o= rg/issues/16105 and/or https://bugs.ruby-lang.org/issues/15946 could be rel= ated, because the region of the Rails code where the corrupted string is cr= eated seems to be doing something similar to the reported issues: https://g= ithub.com/rails/rails/blob/b7e591a55f4de5f1511c3b9255b3b25159b8ba41/actionp= ack/lib/action_dispatch/routing/mapper.rb#L404-L412. Sorry I'm not really sure how to create a reproducible example, or how to d= ebug this issue. Just opening this in case it could help noticing something= obviously wrong with the mentioned patches. -- = https://bugs.ruby-lang.org/ Unsubscribe: