From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 9B5C21F461 for ; Fri, 6 Sep 2019 14:42:55 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id C6A5D120AE2; Fri, 6 Sep 2019 23:42:47 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 179F5120AE2 for ; Fri, 6 Sep 2019 23:42:45 +0900 (JST) Received: by filter0038p3iad2.sendgrid.net with SMTP id filter0038p3iad2-13343-5D727069-1B 2019-09-06 14:42:49.294290538 +0000 UTC m=+252748.816987430 Received: from herokuapp.com (unknown [100.24.30.249]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id ukOm3cC9QVScxrDrOtcgEw for ; Fri, 06 Sep 2019 14:42:49.140 +0000 (UTC) Date: Fri, 06 Sep 2019 14:42:49 +0000 (UTC) From: mame@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 70356 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16136 X-Redmine-Issue-Author: deivid X-Redmine-Sender: mame X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?EJh2gqwnyqXtd++xo=2FinyA1V0bXouTB4FkWnzNiKb48m7MrYCvtfukDLPDQ51P?= =?us-ascii?Q?v6VWWaMnUFpeyOi5X+wzZnt2ILhzzcriJ=2FKDgUa?= =?us-ascii?Q?CzzJZ1WR3U6z9CGbMcBP8pj0ksYC2b1EuXWkIEA?= =?us-ascii?Q?WuoITZCETlLu+Nq2cQus6cS9ExPxzBU4vpCWL+v?= =?us-ascii?Q?=2FU2nKjkyD1S0UypMwcJVkTmfwlvqiDgVbrQ=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 94801 Subject: [ruby-core:94801] [Ruby master Bug#16136] String corruption in 2.6.4 X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16136 has been updated by mame (Yusuke Endoh). I've committed ade1283ca276f7d589ffd3539fbc7b9817f682d5, which is a workaro= und for the issue. I confirm that activeadmin test runs successfully with = this patch. I think that this issue is related to the fstring mechanism, but I have no = idea what function is wrong. The internal state of a String object is too = complicated and undocumented, so I cannot see the design, representation, a= nd invariants. The fstring mechanism is too difficult for human (except @n= ormalperson). = ---------------------------------------- Bug #16136: String corruption in 2.6.4 https://bugs.ruby-lang.org/issues/16136#change-81423 * Author: deivid (David Rodr=EDguez) * Status: Closed * Priority: Normal * Assignee: = * Target version: = * ruby -v: ruby 2.6.4p104 (2019-08-28 revision 67798) [x86_64-linux] * Backport: 2.5: DONTNEED, 2.6: REQUIRED ---------------------------------------- When trying to upgrade activeadmin's tests to use ruby 2.6.4, I got some ve= ry weird failures where some strings would end up containing random content= . See https://circleci.com/gh/activeadmin/activeadmin/20329 for an example = of those failures. Failures are somewhat random but the test suite seems to= consistently fail on 2.6.4 and pass on 2.6.3. I also managed to reproduce = the failures locally, sometimes very consistently, but now it's hardly ever= happening... :/ I looked at the changes in 2.6.4 and it looks like https://bugs.ruby-lang.o= rg/issues/16105 and/or https://bugs.ruby-lang.org/issues/15946 could be rel= ated, because the region of the Rails code where the corrupted string is cr= eated seems to be doing something similar to the reported issues: https://g= ithub.com/rails/rails/blob/b7e591a55f4de5f1511c3b9255b3b25159b8ba41/actionp= ack/lib/action_dispatch/routing/mapper.rb#L404-L412. Sorry I'm not really sure how to create a reproducible example, or how to d= ebug this issue. Just opening this in case it could help noticing something= obviously wrong with the mentioned patches. -- = https://bugs.ruby-lang.org/ Unsubscribe: