ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: hsbt@ruby-lang.org
To: ruby-core@ruby-lang.org
Subject: [ruby-core:94798] [Ruby master Bug#16136] String corruption in 2.6.4
Date: Fri, 06 Sep 2019 12:58:34 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-81419.20190906125834.2aa9b608a0ee9fd3@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-16136.20190903112445@ruby-lang.org

Issue #16136 has been updated by hsbt (Hiroshi SHIBATA).


I faced the same error maybe.

Our company blog generated by middleman was failed with Ruby 2.6.4 and 2.7.0 built by master branch. This issue was completely reproduced with them. We could build with Ruby 2.5.6. 

I will investigate the root causes of this issue.


----------------------------------------
Bug #16136: String corruption in 2.6.4
https://bugs.ruby-lang.org/issues/16136#change-81419

* Author: deivid (David Rodríguez)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.6.4p104 (2019-08-28 revision 67798) [x86_64-linux]
* Backport: 2.5: DONTNEED, 2.6: REQUIRED
----------------------------------------
When trying to upgrade activeadmin's tests to use ruby 2.6.4, I got some very weird failures where some strings would end up containing random content. See https://circleci.com/gh/activeadmin/activeadmin/20329 for an example of those failures. Failures are somewhat random but the test suite seems to consistently fail on 2.6.4 and pass on 2.6.3. I also managed to reproduce the failures locally, sometimes very consistently, but now it's hardly ever happening... :/

I looked at the changes in 2.6.4 and it looks like https://bugs.ruby-lang.org/issues/16105 and/or https://bugs.ruby-lang.org/issues/15946 could be related, because the region of the Rails code where the corrupted string is created seems to be doing something similar to the reported issues: https://github.com/rails/rails/blob/b7e591a55f4de5f1511c3b9255b3b25159b8ba41/actionpack/lib/action_dispatch/routing/mapper.rb#L404-L412.

Sorry I'm not really sure how to create a reproducible example, or how to debug this issue. Just opening this in case it could help noticing something obviously wrong with the mentioned patches.



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

  parent reply	other threads:[~2019-09-06 12:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-16136.20190903112445@ruby-lang.org>
2019-09-03 11:24 ` [ruby-core:94757] [Ruby master Bug#16136] String corruption in 2.6.4 deivid.rodriguez
2019-09-04  0:50 ` [ruby-core:94766] " kevin
2019-09-06  0:16 ` [ruby-core:94792] " XrXr
2019-09-06 10:40 ` [ruby-core:94797] " deivid.rodriguez
2019-09-06 12:58 ` hsbt [this message]
2019-09-06 14:42 ` [ruby-core:94801] " mame
2019-09-06 15:13 ` [ruby-core:94802] " kevin
2019-09-06 15:50 ` [ruby-core:94803] " deivid.rodriguez
2019-09-07  4:48 ` [ruby-core:94814] " mame
2019-09-07  6:53 ` [ruby-core:94817] " deivid.rodriguez
2019-09-07 11:25 ` [ruby-core:94825] " wolf
2019-09-07 13:43 ` [ruby-core:94830] " mame
2019-09-09  1:12 ` [ruby-core:94850] " hsbt
2019-09-14  2:25 ` [ruby-core:94934] " nagachika00
2019-10-01 13:50 ` [ruby-core:95172] " mame
2019-10-01 19:31 ` [ruby-core:95176] " deivid.rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-81419.20190906125834.2aa9b608a0ee9fd3@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).