From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 41B961F461 for ; Tue, 3 Sep 2019 15:32:42 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 17E651209D8; Wed, 4 Sep 2019 00:32:33 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 053C81209D4 for ; Wed, 4 Sep 2019 00:32:29 +0900 (JST) Received: by filter0054p3las1.sendgrid.net with SMTP id filter0054p3las1-31272-5D6E878E-1E 2019-09-03 15:32:30.435825898 +0000 UTC m=+668414.583422365 Received: from herokuapp.com (unknown [54.175.120.76]) by ismtpd0010p1iad1.sendgrid.net (SG) with ESMTP id 5urmrJOTSiW5GdRCDbW3AQ for ; Tue, 03 Sep 2019 15:32:30.325 +0000 (UTC) Date: Tue, 03 Sep 2019 15:32:30 +0000 (UTC) From: jean.boussier@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 70315 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16029 X-Redmine-Issue-Author: byroot X-Redmine-Sender: byroot X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?AchqQMoUBMcQgz7gop0XiYUiatGIY7E61JGsTL4Fvjf9uKNQzn6PHo0f9cW5D7?= =?us-ascii?Q?=2FGNfjaJA+KNSbKDTt+NWUOSUiTcUjGVeYkzJKVf?= =?us-ascii?Q?CnBew3EVdasjEXYpU07ihTkxAEW+n+u4i0Rp3Kx?= =?us-ascii?Q?CoWs7wFlPM1cO0v0u5BH=2FqCbWtGY4sgS5uU3Kn5?= =?us-ascii?Q?+8GjaPFO1oM=2FlmvWGT7qqz5QHfSlQFmCuhQ=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 94761 Subject: [ruby-core:94761] [Ruby master Feature#16029] Expose fstring related APIs to C-extensions X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16029 has been updated by byroot (Jean Boussier). @mame this feature was added by @nobu in the last developer's meeting issue [#15996], but I suppose it wasn't discussed by lack of time. Should I just add it back to the next developer's meeting issue once it is created? ---------------------------------------- Feature #16029: Expose fstring related APIs to C-extensions https://bugs.ruby-lang.org/issues/16029#change-81375 * Author: byroot (Jean Boussier) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- As discussed with @tenderlove here: https://github.com/ruby/ruby/pull/2287#issuecomment-513865160 We'd like to update various data format parsers (JSON, MessagePack, etc) to add the possibility to deduplicate strings while parsing. But unfortunately the `rb_fstring_*` family of functions isn't available to C-extensions, so the only available fallback is `rb_funcall(str, rb_intern("-@"))` which most parsers will likely consider too slow. So the various `rb_fstring_*` functions would need to be public. Proposed patch: https://github.com/ruby/ruby/pull/2299 -- https://bugs.ruby-lang.org/