From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id BBF6A1F461 for ; Fri, 30 Aug 2019 16:57:43 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 82DF8120C04; Sat, 31 Aug 2019 01:57:35 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 360B1120AB2 for ; Sat, 31 Aug 2019 01:57:33 +0900 (JST) Received: by filter0154p3mdw1.sendgrid.net with SMTP id filter0154p3mdw1-18799-5D69557C-3A 2019-08-30 16:57:32.828508941 +0000 UTC m=+247859.463808458 Received: from herokuapp.com (unknown [18.206.95.224]) by ismtpd0010p1iad1.sendgrid.net (SG) with ESMTP id 3oqMxaw3T12ZH1RHgqMG_Q for ; Fri, 30 Aug 2019 16:57:32.854 +0000 (UTC) Date: Fri, 30 Aug 2019 16:57:32 +0000 (UTC) From: daniel@dan42.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 70239 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16131 X-Redmine-Issue-Author: naruse X-Redmine-Sender: Dan0042 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?8sy4RigFvRTdBfCVJrT9zb2J88PC92TMQwdNgaWYaq6gkWPd+XCU09r+XzD2Gr?= =?us-ascii?Q?VUE914ej9TT2nw7Kmx8K28giXW4NzbqpP+kmphp?= =?us-ascii?Q?h3ryLCR7ePtn4u=2FzcFAIL8+RuIh2a=2FqsQbfIy=2Fo?= =?us-ascii?Q?Nyfi31LeKOq2db3LO92hzCmmNgGmyQ4uYhxen+g?= =?us-ascii?Q?sjurSDixxgSvFqEQCKvuOL3UMgdi+jSafyg=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 94687 Subject: [ruby-core:94687] [Ruby master Feature#16131] Remove $SAFE, taint and trust X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16131 has been updated by Dan0042 (Daniel DeLorme). @jeremyevans0, by "no-op" did you mean only in the context of $SAFE mode, or did you mean that `tainted?` and `trusted?` would always return false? In the second case I think it's better to just remove the method, at least that's an obvious and easy bug to fix. ---------------------------------------- Feature #16131: Remove $SAFE, taint and trust https://bugs.ruby-lang.org/issues/16131#change-81293 * Author: naruse (Yui NARUSE) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- Ruby had Taint checking which is originally introduced in Perl. https://en.wikipedia.org/wiki/Taint_checking It was intended to provide a useful tool for handle objects which are come from outside. Input data is set as tainted by default and call untaint if you checked or filtered the value. Some people used this feature in the age of CGI. But these days, no one use the mechanism and input libraries usually doesn't support it. For example rack, as following shows its input is not tainted and the mechanism is unusable. ``` % cat foo.ru run ->(env) do ['200', {'Content-Type' => 'text/plain'}, ["Is QUERY_STRING tainted?: #{env["QUERY_STRING"].tainted?}"]] end % rackup foo.ru [51724] Puma starting in cluster mode... [51724] * Version 3.12.1 (ruby 2.6.3-p62), codename: Llamas in Pajamas [51724] * Min threads: 3, max threads: 3 [51724] * Environment: development [51724] * Process workers: 1 [51724] * Preloading application [51724] * Listening on tcp://localhost:9292 [51724] Use Ctrl-C to stop [51737] + Gemfile in context: /Users/naruse/work/td-cdp-api/Gemfile [51724] - Worker 0 (pid: 51737) booted, phase: 0 ``` ``` % curl http://localhost:9292/\?foo=1 Is QUERY_STRING tainted?: false ``` Therefore I think Taint checking mechanism is unusable on the current Ruby ecosystem. On the other hand we experienced multiple vulnerability around $SAFE and taint mechanism. https://cse.google.com/cse?q=taint&cx=008288045305770251182%3Afvruzsaknew&ie=UTF-8 The cost of maintaining it is expensive. In conclusion, I think the taint mechanism is too expensive to maintain for the merit of it. I suggest to remove it. -- https://bugs.ruby-lang.org/