From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 8817B1F461 for ; Thu, 29 Aug 2019 07:09:23 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 4042F120C1E; Thu, 29 Aug 2019 16:09:15 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id A7B71120C21 for ; Thu, 29 Aug 2019 16:09:10 +0900 (JST) Received: by filter0031p3las1.sendgrid.net with SMTP id filter0031p3las1-27611-5D677A16-1B 2019-08-29 07:09:10.32338416 +0000 UTC m=+211448.240640906 Received: from herokuapp.com (unknown [54.227.36.202]) by ismtpd0030p1mdw1.sendgrid.net (SG) with ESMTP id PsTpOT8JQI2OgfpaFjVg0A for ; Thu, 29 Aug 2019 07:09:10.248 +0000 (UTC) Date: Thu, 29 Aug 2019 07:09:10 +0000 (UTC) From: matz@ruby.or.jp Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 70208 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15815 X-Redmine-Issue-Author: mtsmfm X-Redmine-Sender: matz X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?bXEIHGfdFwsIlBTndiToCp=2Fmc2rfxRD2sZAksRKJIHVKP4=2FiQfEk6s66Neqf+W?= =?us-ascii?Q?eqKjVDUUL5Mi5XuM=2FESheRuF1SNKlBnIRLJPMyo?= =?us-ascii?Q?I19xivxM2NAKXdZkOW9Tbc6CnuDFQbWg7kUcp6+?= =?us-ascii?Q?Y7EH5NNOJNhtLHJBMVD7pQJN7xOgacVPthobOT0?= =?us-ascii?Q?ixHNlVMc=2FbcifVeiSQt0GVYrpvHAIEmYFOw=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 94656 Subject: [ruby-core:94656] [Ruby master Feature#15815] Add option to raise NoMethodError for OpenStruct X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15815 has been updated by matz (Yukihiro Matsumoto). I like the idea. It's up to @marcandre Matz. ---------------------------------------- Feature #15815: Add option to raise NoMethodError for OpenStruct https://bugs.ruby-lang.org/issues/15815#change-81255 * Author: mtsmfm (Fumiaki Matsushima) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- GitHub PR: https://github.com/ruby/ruby/pull/2164 Currently, `OpenStruct#method_missing` returns `nil` even if the key isn't registered. ```ruby require 'ostruct' os = OpenStruct.new({a: 1}) os.a #=> 1 os.b #=> nil ``` I'd like to add `exception` option to raise `NoMethodError` in such case. ```ruby require 'ostruct' os = OpenStruct.new({a: 1}, exception: true) os.a #=> 1 os.b #=> NoMethodError ``` ## Use case I sometimes use OpenStruct as a JSON API response wrapper. It's useful to use method call instead of key access (`obj[:key]`) because we can use `Symbol#to_proc` if it's a method (for example `users.map(&:id)`) But I want to prevent typo for a key name. Currently `users.map(&:idd)` just returns `[nil,...]` Even if we have this `exception` option, we can't enable this option for JSON parser easily though: ```ruby JSON.parse(response, object_class: Class.new(OpenStruct) { def initialize(hash); super(hash, exception: true); end }) ``` What do you think? ---- I've searched with "openstruct nomethoderror" on bugs.ruby-lang.org though, please let me know if it's duplicated. https://bugs.ruby-lang.org/search?utf8=%E2%9C%93&scope=&q=nomethoderror+openstruct -- https://bugs.ruby-lang.org/