* [ruby-core:89191] [Ruby trunk Bug#15170] Allow WEBrick::HTTPServlet::initialize to accept an array in server[:CGIInterpreter]
[not found] <redmine.issue-15170.20180927155413@ruby-lang.org>
@ 2018-09-27 15:54 ` remi.lapeyre
2018-09-27 22:18 ` [ruby-core:89198] " shevegen
` (2 subsequent siblings)
3 siblings, 0 replies; 4+ messages in thread
From: remi.lapeyre @ 2018-09-27 15:54 UTC (permalink / raw
To: ruby-core
Issue #15170 has been reported by remi.lapeyre (Rémi Lapeyre).
----------------------------------------
Bug #15170: Allow WEBrick::HTTPServlet::initialize to accept an array in server[:CGIInterpreter]
https://bugs.ruby-lang.org/issues/15170
* Author: remi.lapeyre (Rémi Lapeyre)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
* ruby -v:
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
There is currently no nice way to give WEBrick::HTTPServlet a command with arguments as an array. This force scripts to escape the paths to the given command.
One way to let people specify either a string or an array of strings would be to set `cgicmd` as a string or an array based on the type of `server[:CGIInterpreter]`. This should be a backward compatible change if I understand the code correctly.
I never wrote Ruby but could try to submit a pull request if you think this change could be a good idea.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 4+ messages in thread
* [ruby-core:89198] [Ruby trunk Bug#15170] Allow WEBrick::HTTPServlet::initialize to accept an array in server[:CGIInterpreter]
[not found] <redmine.issue-15170.20180927155413@ruby-lang.org>
2018-09-27 15:54 ` [ruby-core:89191] [Ruby trunk Bug#15170] Allow WEBrick::HTTPServlet::initialize to accept an array in server[:CGIInterpreter] remi.lapeyre
@ 2018-09-27 22:18 ` shevegen
2019-01-04 3:58 ` [ruby-core:90883] [Ruby trunk Bug#15170][Assigned] " hsbt
2019-08-27 4:45 ` [ruby-core:94599] [Ruby master Feature#15170] " merch-redmine
3 siblings, 0 replies; 4+ messages in thread
From: shevegen @ 2018-09-27 22:18 UTC (permalink / raw
To: ruby-core
Issue #15170 has been updated by shevegen (Robert A. Heiler).
I do not have any pro or con opinion (I rarely use webrick these days) but I
think if you can retain backward compatibility then this may make any patch
in this regard a lot easier.
If you have the time, I would like to suggest to you to consider having a
look at the code over a weekend or another one and consider a pull request -
even if it may not be perfect, I am sure others can comment on it leading
to improvements.
I think what may help the most, though, is if you can manage to get one or
the other from the ruby core team to comment on the proposal; from my
experience this helps quite a bit. (And you can also suggest it for a
ruby developer meeting, even though it is a very small change; but perhaps
small changes can be discussed quickly. I do not know how the developer
meetings work in practice, but I assume that certain issues take a lot
more time to discuss.)
Next developer meeting is here:
https://bugs.ruby-lang.org/issues/15129
But of course you can also wait and let others comment on the issue here,
which may take some time perhaps.
----------------------------------------
Bug #15170: Allow WEBrick::HTTPServlet::initialize to accept an array in server[:CGIInterpreter]
https://bugs.ruby-lang.org/issues/15170#change-74223
* Author: remi.lapeyre (Rémi Lapeyre)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
* ruby -v:
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
There is currently no nice way to give WEBrick::HTTPServlet a command with arguments as an array. This force scripts to escape the paths to the given command.
One way to let people specify either a string or an array of strings would be to set `cgicmd` as a string or an array based on the type of `server[:CGIInterpreter]`. This should be a backward compatible change if I understand the code correctly.
I never wrote Ruby but could try to submit a pull request if you think this change could be a good idea.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 4+ messages in thread
* [ruby-core:90883] [Ruby trunk Bug#15170][Assigned] Allow WEBrick::HTTPServlet::initialize to accept an array in server[:CGIInterpreter]
[not found] <redmine.issue-15170.20180927155413@ruby-lang.org>
2018-09-27 15:54 ` [ruby-core:89191] [Ruby trunk Bug#15170] Allow WEBrick::HTTPServlet::initialize to accept an array in server[:CGIInterpreter] remi.lapeyre
2018-09-27 22:18 ` [ruby-core:89198] " shevegen
@ 2019-01-04 3:58 ` hsbt
2019-08-27 4:45 ` [ruby-core:94599] [Ruby master Feature#15170] " merch-redmine
3 siblings, 0 replies; 4+ messages in thread
From: hsbt @ 2019-01-04 3:58 UTC (permalink / raw
To: ruby-core
Issue #15170 has been updated by hsbt (Hiroshi SHIBATA).
Status changed from Open to Assigned
Assignee set to normalperson (Eric Wong)
----------------------------------------
Bug #15170: Allow WEBrick::HTTPServlet::initialize to accept an array in server[:CGIInterpreter]
https://bugs.ruby-lang.org/issues/15170#change-76070
* Author: remi.lapeyre (Rémi Lapeyre)
* Status: Assigned
* Priority: Normal
* Assignee: normalperson (Eric Wong)
* Target version:
* ruby -v:
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
There is currently no nice way to give WEBrick::HTTPServlet a command with arguments as an array. This force scripts to escape the paths to the given command.
One way to let people specify either a string or an array of strings would be to set `cgicmd` as a string or an array based on the type of `server[:CGIInterpreter]`. This should be a backward compatible change if I understand the code correctly.
I never wrote Ruby but could try to submit a pull request if you think this change could be a good idea.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 4+ messages in thread
* [ruby-core:94599] [Ruby master Feature#15170] Allow WEBrick::HTTPServlet::initialize to accept an array in server[:CGIInterpreter]
[not found] <redmine.issue-15170.20180927155413@ruby-lang.org>
` (2 preceding siblings ...)
2019-01-04 3:58 ` [ruby-core:90883] [Ruby trunk Bug#15170][Assigned] " hsbt
@ 2019-08-27 4:45 ` merch-redmine
3 siblings, 0 replies; 4+ messages in thread
From: merch-redmine @ 2019-08-27 4:45 UTC (permalink / raw
To: ruby-core
Issue #15170 has been updated by jeremyevans0 (Jeremy Evans).
Backport deleted (2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN)
Tracker changed from Bug to Feature
I agree that this is a feature request and not a bug report. I think this is a useful feature, and have submitted a pull request to implement it: https://github.com/ruby/webrick/pull/25
----------------------------------------
Feature #15170: Allow WEBrick::HTTPServlet::initialize to accept an array in server[:CGIInterpreter]
https://bugs.ruby-lang.org/issues/15170#change-81076
* Author: remi.lapeyre (Rémi Lapeyre)
* Status: Assigned
* Priority: Normal
* Assignee: normalperson (Eric Wong)
* Target version:
----------------------------------------
There is currently no nice way to give WEBrick::HTTPServlet a command with arguments as an array. This force scripts to escape the paths to the given command.
One way to let people specify either a string or an array of strings would be to set `cgicmd` as a string or an array based on the type of `server[:CGIInterpreter]`. This should be a backward compatible change if I understand the code correctly.
I never wrote Ruby but could try to submit a pull request if you think this change could be a good idea.
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-27 4:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <redmine.issue-15170.20180927155413@ruby-lang.org>
2018-09-27 15:54 ` [ruby-core:89191] [Ruby trunk Bug#15170] Allow WEBrick::HTTPServlet::initialize to accept an array in server[:CGIInterpreter] remi.lapeyre
2018-09-27 22:18 ` [ruby-core:89198] " shevegen
2019-01-04 3:58 ` [ruby-core:90883] [Ruby trunk Bug#15170][Assigned] " hsbt
2019-08-27 4:45 ` [ruby-core:94599] [Ruby master Feature#15170] " merch-redmine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).