ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: mame@ruby-lang.org
To: ruby-core@ruby-lang.org
Subject: [ruby-core:94489] [Ruby master Feature#16115] Keyword arguments from method calls or ignore extra hash keys in splat
Date: Fri, 23 Aug 2019 00:53:42 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-80924.20190823005342.23f1123afd4ca717@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-16115.20190822120133@ruby-lang.org

Issue #16115 has been updated by mame (Yusuke Endoh).


Thank you for proposing ideas.  They are interesting to me.

As you said in your second example, it is only possible in callee side: changing the method definition to accept a dummy `**` argument.

```
def hello(who:, **)
end

hello(who: "world", foo: "bar")
```

It is difficult to do so in the caller side.  (It is theoretically possible by using `Method#parameters`, but it is an evil magic.)


> 1) What if when you passed an object as an argument to a method that only accepts keyword arguments, the methods listed would be called?

I have never thought this.  Very interesting, but it looks a too big semantics change just for solving the problem.

> 2) Or perhaps add some sort of "triple splat" that would either a) do the method calling thing described above or b) do the regular hash splatting like ** but ignore any keys present that are not listed as keyword arguments:

I have never thought this, nethier.  I have never spent time to consider it yet, but as my first impression, it looks a good idea.  I'd like to hear opinions from matz and people.

----------------------------------------
Feature #16115: Keyword arguments from method calls or ignore extra hash keys in splat
https://bugs.ruby-lang.org/issues/16115#change-80924

* Author: kke (Kimmo Lehto)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
Just a thought, feel free to insta-close as stupid.

Currently you can do this:

```
def hello(who:)
  puts "Hello, #{who}"
end

opts = { who: 'world' }
hello(who)
```

Or: 

```
def hello(who:, **_extra_opts) # without eating extra args, you get ArgumentError (unknown keyword: foo)
  puts "Hello, #{who}!"
end

hello(**{ who: 'world', foo: 'bar' })
```

Or even this:

```
def hello(_obj = nil, who: _obj&.who || raise(ArgumentError, "missing who:"))
  puts "Hello, #{who}!"
end

hello(OpenStruct.new(who: 'world'))
```

1) What if when you passed an object as an argument to a method that only accepts keyword arguments, the methods listed would be called? Then you could do:

```
require 'ostruct'
ostruct = OpenStruct.new(who: 'world, foo: 'bar')

def hello(who:)
  puts "Hello, #{who}!"
end

hello(ostruct)
```

2) Or perhaps add some sort of "triple splat" that would either a) do the method calling thing described above or b) do the regular hash splatting like `**` but ignore any keys present that are not listed as keyword arguments:

```
require 'ostruct'
ostruct = OpenStruct.new(who: 'world', foo: 'bar')

def hello(who:)
  puts "Hello, #{who}!"
end

# a:  
hello(***ostruct)  # would call ostruct.who to figure out `who:`

# or b: (currently with ** raises ArgumentError (unknown keyword: foo))
hello(***{ who: 'world', foo: 'bar' }) # would ignore any extra keys 
```

I think this could open up some possibilities (or a can of worms). 




-- 
https://bugs.ruby-lang.org/

      parent reply	other threads:[~2019-08-23  0:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-16115.20190822120133@ruby-lang.org>
2019-08-22 12:01 ` [ruby-core:94480] [Ruby master Feature#16115] Keyword arguments from method calls or ignore extra hash keys in splat kimmo.lehto
2019-08-22 19:56 ` [ruby-core:94485] " shevegen
2019-08-23  0:53 ` mame [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-80924.20190823005342.23f1123afd4ca717@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).