From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id D06EF1F461 for ; Wed, 21 Aug 2019 14:51:32 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 9AA0C1209D6; Wed, 21 Aug 2019 23:51:24 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 54DC41209C4 for ; Wed, 21 Aug 2019 23:51:22 +0900 (JST) Received: by filter0062p3iad2.sendgrid.net with SMTP id filter0062p3iad2-6655-5D5D5A6C-52 2019-08-21 14:51:24.913269914 +0000 UTC m=+482919.494538256 Received: from herokuapp.com (unknown [54.226.103.57]) by ismtpd0012p1iad1.sendgrid.net (SG) with ESMTP id K5dNtgyGSP6lnIHw5A3Fpg for ; Wed, 21 Aug 2019 14:51:24.805 +0000 (UTC) Date: Wed, 21 Aug 2019 14:51:25 +0000 (UTC) From: merch-redmine@jeremyevans.net Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 70009 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 16112 X-Redmine-Issue-Author: k0kubun X-Redmine-Sender: jeremyevans0 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?RVE3t853K5scBhbmJHUzZTFFeVC=2FZSUmHZ0Dc+26wcEi2CTgsF1oz0wTSSxGGN?= =?us-ascii?Q?BIJo+TnuojidcfFhQFPNmw5q2Atrd4nY45ONpXO?= =?us-ascii?Q?ndOnYqy9EEqtunA3Dy8WIbrEG9rzNvESEv8kI7z?= =?us-ascii?Q?Jeyrcsslbr34ctBH9lCu7JnqfcqMeKMrXiFuLz=2F?= =?us-ascii?Q?Cs+Y24SrW3k2YgddGnHbMzg2qZPdkKC2czQ=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 94460 Subject: [ruby-core:94460] [Ruby master Misc#16112] Reduce the possibility of "expand tabs" commit occurrences X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #16112 has been updated by jeremyevans0 (Jeremy Evans). Here are my opinions on the options: 0) I'm in favor of this. I certainly encourage the use of spaces over tabs, but auto commits for indentation changes are unnecessary and I don't think the benefit outweighs the cost. 1) I'm against this as it will make merging old patches more difficult, and that is something I've been doing a lot of in my bug triaging work. 2) I'm against this. If we do keep the "expand tabs", then it should be applied to modified lines as well as new lines, so that we move in the direction of fewer tabs. 3) I'm in favor of this and would use it, since it is easier for me than trying to expand the tabs manually. 4) I'm against this as it places an additional burden on contributors. 5) I'm against this for the same reason as k0kubun (Takashi Kokubun). ---------------------------------------- Misc #16112: Reduce the possibility of "expand tabs" commit occurrences https://bugs.ruby-lang.org/issues/16112#change-80893 * Author: k0kubun (Takashi Kokubun) * Status: Open * Priority: Normal * Assignee: ---------------------------------------- ## Problem * While we agreed to use only spaces for indentation of C code in [Bug #14246], we sometimes hit "expand tabs" commit when we just edit a part of existing lines with hard tab indentation. * "expand tabs" commit bothers people when we need to perform a revert or a backport. * However, because [Bug #14246] aimed to eventually make indentations consistent, we do not want to just drop "expand tabs". * One of the motivations to solve [Bug #14246] is that having hard tabs makes preprocessed MJIT header ugly and it makes debugging on GCC hard. As MJIT may introduce C-code inlining for sources outside vm.c in the future, we want to fix the issue in almost all C sources which can be run on runtime. ## Possible Solutions There would be some options to approach the problem. I'd like to hear opinions about these options. 1. Expand all tabs at once for all files managed by auto-style. * In [Bug #14246], this was clearly objected for the reason "Indents should become consistent over time". * In my understanding, not folliwng "Indents should become consistent over time" would be problematic mainly for polluting "git blame" and conflicts on backport. * For the first point, we can use `-w` option of `git blame` to ignore that. * For backport, it's a trade-off with many "expand tabs" commits. We need opinions about this from @usa and @nagachika . * Also reverting a commit before the commit expanding all tabs would be bothering, for a short while. 2. Skip expand tabs for existing lines when indentation is not changed, and expand tabs only in newly-added lines. * If editors are configured properly, "expand tabs" would not happen for new patches in this approach. * Even in this approach, at least we will not go to the opposite direction of eventually achieving [Bug #14246]. So it seems acceptable. 3. Prepare a local pre-commit hook to perform "expand tabs", and let people who do not want "expand tabs" use it. 4. Make pull request CI fail when there's diff to be expanded, and let people who do not want "expand tabs" commit things from pull requests. ---Files-------------------------------- Screen Shot 2019-08-19 at 2.43.06 PM.png (48.8 KB) -- https://bugs.ruby-lang.org/