[ruby-core:45062] [ruby-trunk - Bug #6436][Open] Byte counting incorrect in BufferedIO (net/protocol.rb)

[ruby-core:45062] [ruby-trunk - Bug #6436][Open] Byte counting incorrect in BufferedIO (net/protocol.rb)

[jcast (Jeremie Castagna)]

Issue #6436 has been reported by jcast (Jeremie Castagna).

----------------------------------------
Bug #6436: Byte counting incorrect in BufferedIO (net/protocol.rb)
https://bugs.ruby-lang.org/issues/6436

Author: jcast (Jeremie Castagna)
Status: Open
Priority: Normal
Assignee: 
Category: 
Target version: 
ruby -v: 1.9


BufferedIO's @rbuf counts bytes with String#size, but should use String#bytesize. This creates potential incorrect reading of a HTTP body when changing the encoding of each chuck passed by HTTP#read_body:

http.read_body do |chunk|
  chunk.force_encoding "UTF-8"
end


-- 
http://bugs.ruby-lang.org/

[ruby-core:45063] [ruby-trunk - Bug #6436] Byte counting incorrect in BufferedIO (net/protocol.rb)

[jcast (Jeremie Castagna)]

Issue #6436 has been updated by jcast (Jeremie Castagna).

File protocol.patch added

Patch file.
----------------------------------------
Bug #6436: Byte counting incorrect in BufferedIO (net/protocol.rb)
https://bugs.ruby-lang.org/issues/6436#change-26645

Author: jcast (Jeremie Castagna)
Status: Open
Priority: Normal
Assignee: 
Category: 
Target version: 
ruby -v: 1.9


BufferedIO's @rbuf counts bytes with String#size, but should use String#bytesize. This creates potential incorrect reading of a HTTP body when changing the encoding of each chuck passed by HTTP#read_body:

http.read_body do |chunk|
  chunk.force_encoding "UTF-8"
end


-- 
http://bugs.ruby-lang.org/

[ruby-core:45068] Re: [ruby-trunk - Bug #6436] Byte counting incorrect in BufferedIO (net/protocol.rb)

[Eric Wong]

"jcast (Jeremie Castagna)" <jeremie.castagna@gmail.com> wrote:
> File protocol.patch added
> 
> Patch file.

Can you send the patch with unified diff format?  (diff -u)

It's the default format of both svn and git, and generally easier to
read/review.  Thanks.

[ruby-core:45070] [ruby-trunk - Bug #6436] Byte counting incorrect in BufferedIO (net/protocol.rb)

[nobu (Nobuyoshi Nakada)]

Issue #6436 has been updated by nobu (Nobuyoshi Nakada).

File protocol.patch added

Emacs diff-mode.el provides a function, diff-context->unified.
----------------------------------------
Bug #6436: Byte counting incorrect in BufferedIO (net/protocol.rb)
https://bugs.ruby-lang.org/issues/6436#change-26649

Author: jcast (Jeremie Castagna)
Status: Open
Priority: Normal
Assignee: 
Category: 
Target version: 
ruby -v: 1.9


BufferedIO's @rbuf counts bytes with String#size, but should use String#bytesize. This creates potential incorrect reading of a HTTP body when changing the encoding of each chuck passed by HTTP#read_body:

http.read_body do |chunk|
  chunk.force_encoding "UTF-8"
end


-- 
http://bugs.ruby-lang.org/

[ruby-core:45094] [ruby-trunk - Bug #6436][Assigned] Byte counting incorrect in BufferedIO (net/protocol.rb)

[mame (Yusuke Endoh)]

Issue #6436 has been updated by mame (Yusuke Endoh).

Status changed from Open to Assigned
Assignee set to nobu (Nobuyoshi Nakada)

Thanks Jeremie,
Could you add a test to test/net/http/test_buffered_io.rb ?

Nobu, can you review the patch?

-- 
Yusuke Endoh <mame@tsg.ne.jp>
----------------------------------------
Bug #6436: Byte counting incorrect in BufferedIO (net/protocol.rb)
https://bugs.ruby-lang.org/issues/6436#change-26667

Author: jcast (Jeremie Castagna)
Status: Assigned
Priority: Normal
Assignee: nobu (Nobuyoshi Nakada)
Category: 
Target version: 
ruby -v: 1.9


BufferedIO's @rbuf counts bytes with String#size, but should use String#bytesize. This creates potential incorrect reading of a HTTP body when changing the encoding of each chuck passed by HTTP#read_body:

http.read_body do |chunk|
  chunk.force_encoding "UTF-8"
end


-- 
http://bugs.ruby-lang.org/

[ruby-core:94361] [Ruby master Bug#6436] Byte counting incorrect in BufferedIO (net/protocol.rb)

[merch-redmine]

Issue #6436 has been updated by jeremyevans0 (Jeremy Evans).

Status changed from Assigned to Closed

It looks like this issue was fixed between Ruby 2.4 and 2.5:

```
$ ruby24 -rnet/http -e "p Net::HTTP.start('www.falcom.co.jp', 443, :use_ssl=>true){|http| http.request_get('/'){|res| res.read_body{|c| p c.bytesize;  c.force_encoding 'UTF-8'}}}" 
0
16384
16384
16384
4604
2
5
0
16384
16384
16384
4604
2
5
-e: end of file reached (EOFError)

$ ruby24 -rnet/http -e "p Net::HTTP.start('www.falcom.co.jp', 443, :use_ssl=>true){|http| http.request_get('/'){|res| res.read_body{|c| p c.bytesize}}}"                            
0
16384
16384
16384
4604
#<Net::HTTPOK 200 OK readbody=true>

$ ruby25 -rnet/http -e "p Net::HTTP.start('www.falcom.co.jp', 443, :use_ssl=>true){|http| http.request_get('/'){|res| res.read_body{|c| p c.bytesize;  c.force_encoding 'UTF-8'}}}" 
0
16384
16384
16384
4604
#<Net::HTTPOK 200 OK readbody=true>
```



----------------------------------------
Bug #6436: Byte counting incorrect in BufferedIO (net/protocol.rb)
https://bugs.ruby-lang.org/issues/6436#change-80771

* Author: jcast (Jeremie Castagna)
* Status: Closed
* Priority: Normal
* Assignee: nobu (Nobuyoshi Nakada)
* Target version: 
* ruby -v: 1.9
* Backport: 
----------------------------------------
BufferedIO's @rbuf counts bytes with String#size, but should use String#bytesize. This creates potential incorrect reading of a HTTP body when changing the encoding of each chuck passed by HTTP#read_body:

http.read_body do |chunk|
  chunk.force_encoding "UTF-8"
end

---Files--------------------------------
protocol.patch (4.39 KB)
protocol.patch (2.63 KB)


-- 
https://bugs.ruby-lang.org/