* [ruby-core:94277] [Ruby master Bug#16097] [PATCH] Don't accidentally name anonymous module/class
[not found] <redmine.issue-16097.20190811154014@ruby-lang.org>
@ 2019-08-11 15:40 ` XrXr
2019-08-13 23:48 ` [ruby-core:94330] " nobu
2019-08-14 1:23 ` [ruby-core:94333] " XrXr
2 siblings, 0 replies; 3+ messages in thread
From: XrXr @ 2019-08-11 15:40 UTC (permalink / raw)
To: ruby-core
Issue #16097 has been reported by alanwu (Alan Wu).
----------------------------------------
Bug #16097: [PATCH] Don't accidentally name anonymous module/class
https://bugs.ruby-lang.org/issues/16097
* Author: alanwu (Alan Wu)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
* ruby -v:
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
My patch in #15765 accidentally introduced a behavior change.
`ruby -ve 'Module.new { class self::A; end; p name }'` outputs a name
similar to `Module#inspect` when it should output `nil` like in Ruby 2.6.x.
I have a pull request to fix this: https://github.com/ruby/ruby/pull/2337
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ruby-core:94330] [Ruby master Bug#16097] [PATCH] Don't accidentally name anonymous module/class
[not found] <redmine.issue-16097.20190811154014@ruby-lang.org>
2019-08-11 15:40 ` [ruby-core:94277] [Ruby master Bug#16097] [PATCH] Don't accidentally name anonymous module/class XrXr
@ 2019-08-13 23:48 ` nobu
2019-08-14 1:23 ` [ruby-core:94333] " XrXr
2 siblings, 0 replies; 3+ messages in thread
From: nobu @ 2019-08-13 23:48 UTC (permalink / raw)
To: ruby-core
Issue #16097 has been updated by nobu (Nobuyoshi Nakada).
Could you rebase the PR with adding this reference `[Bug #16097]` to the commit log?
----------------------------------------
Bug #16097: [PATCH] Don't accidentally name anonymous module/class
https://bugs.ruby-lang.org/issues/16097#change-80722
* Author: alanwu (Alan Wu)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
* ruby -v:
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
My patch in #15765 accidentally introduced a behavior change.
`ruby -ve 'Module.new { class self::A; end; p name }'` outputs a name
similar to `Module#inspect` when it should output `nil` like in Ruby 2.6.x.
I have a pull request to fix this: https://github.com/ruby/ruby/pull/2337
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ruby-core:94333] [Ruby master Bug#16097] [PATCH] Don't accidentally name anonymous module/class
[not found] <redmine.issue-16097.20190811154014@ruby-lang.org>
2019-08-11 15:40 ` [ruby-core:94277] [Ruby master Bug#16097] [PATCH] Don't accidentally name anonymous module/class XrXr
2019-08-13 23:48 ` [ruby-core:94330] " nobu
@ 2019-08-14 1:23 ` XrXr
2 siblings, 0 replies; 3+ messages in thread
From: XrXr @ 2019-08-14 1:23 UTC (permalink / raw)
To: ruby-core
Issue #16097 has been updated by alanwu (Alan Wu).
Done. The [latest commit](https://github.com/ruby/ruby/pull/2337/commits/36e00760a42a09266521fc503a0bda7af632a4e3) has a reference to this ticket.
----------------------------------------
Bug #16097: [PATCH] Don't accidentally name anonymous module/class
https://bugs.ruby-lang.org/issues/16097#change-80725
* Author: alanwu (Alan Wu)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
* ruby -v:
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
My patch in #15765 accidentally introduced a behavior change.
`ruby -ve 'Module.new { class self::A; end; p name }'` outputs a name
similar to `Module#inspect` when it should output `nil` like in Ruby 2.6.x.
I have a pull request to fix this: https://github.com/ruby/ruby/pull/2337
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-14 1:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <redmine.issue-16097.20190811154014@ruby-lang.org>
2019-08-11 15:40 ` [ruby-core:94277] [Ruby master Bug#16097] [PATCH] Don't accidentally name anonymous module/class XrXr
2019-08-13 23:48 ` [ruby-core:94330] " nobu
2019-08-14 1:23 ` [ruby-core:94333] " XrXr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).