From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.8 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 5770F1F45A for ; Tue, 13 Aug 2019 10:15:14 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id DB295120907; Tue, 13 Aug 2019 19:15:06 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 1E3D112080B for ; Tue, 13 Aug 2019 19:15:04 +0900 (JST) Received: by filter0076p3iad2.sendgrid.net with SMTP id filter0076p3iad2-27506-5D528DAB-4F 2019-08-13 10:15:07.688953846 +0000 UTC m=+1523686.826686201 Received: from herokuapp.com (unknown [3.81.120.68]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id 28FPYkqqSOG6pchFNsWBPg for ; Tue, 13 Aug 2019 10:15:07.452 +0000 (UTC) Date: Tue, 13 Aug 2019 10:15:07 +0000 (UTC) From: manga.osyo@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 69868 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15815 X-Redmine-Issue-Author: mtsmfm X-Redmine-Sender: osyo X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?EoIqruA4Er0CjiyK1+U6TJuuQMCAZ3OX2ybarlx6ke5ZbuDuwjjySqNAkYSh3=2F?= =?us-ascii?Q?t8k9rzCay4gTCRfgNmx+1zuy9F5P90eHwqIjA8G?= =?us-ascii?Q?wMQzdaaqyWpo3CObxh9iOfrxB7dluYDBM+GqSpP?= =?us-ascii?Q?i6FTn0xweccyf3sfY3OjUuEbVZhGa7ojjOG0+fz?= =?us-ascii?Q?=2FRXO9EZ8wYIYOq3C320cKqHTiw0MQLO9ohA=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 94321 Subject: [ruby-core:94321] [Ruby master Feature#15815] Add option to raise NoMethodError for OpenStruct X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15815 has been updated by osyo (manga osyo). What about adding block arguments to `OpenStruct.new` like `Hash` instead of options? ```ruby h = Hash.new {|hash, key| raise(IndexError, "hash[#{key}] has no value") } # Error: in `block in
': hash[1] has no value (IndexError) h[1] require "ostruct" # Adding block arguments like Hash os = OpenStruct.new({a: 1}) {|open_struct, method_name| raise(NoMethdError, "undefined method `#{method_name}' for #{open_struct}") } # Error: in `block in
': undefined method `b' for # (NoMethodError) os.b ``` ---------------------------------------- Feature #15815: Add option to raise NoMethodError for OpenStruct https://bugs.ruby-lang.org/issues/15815#change-80708 * Author: mtsmfm (Fumiaki Matsushima) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- GitHub PR: https://github.com/ruby/ruby/pull/2164 Currently, `OpenStruct#method_missing` returns `nil` even if the key isn't registered. ```ruby require 'ostruct' os = OpenStruct.new({a: 1}) os.a #=> 1 os.b #=> nil ``` I'd like to add `exception` option to raise `NoMethodError` in such case. ```ruby require 'ostruct' os = OpenStruct.new({a: 1}, exception: true) os.a #=> 1 os.b #=> NoMethodError ``` ## Use case I sometimes use OpenStruct as a JSON API response wrapper. It's useful to use method call instead of key access (`obj[:key]`) because we can use `Symbol#to_proc` if it's a method (for example `users.map(&:id)`) But I want to prevent typo for a key name. Currently `users.map(&:idd)` just returns `[nil,...]` Even if we have this `exception` option, we can't enable this option for JSON parser easily though: ```ruby JSON.parse(response, object_class: Class.new(OpenStruct) { def initialize(hash); super(hash, exception: true); end }) ``` What do you think? ---- I've searched with "openstruct nomethoderror" on bugs.ruby-lang.org though, please let me know if it's duplicated. https://bugs.ruby-lang.org/search?utf8=%E2%9C%93&scope=&q=nomethoderror+openstruct -- https://bugs.ruby-lang.org/