From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.6 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id C5D421F45A for ; Tue, 13 Aug 2019 09:30:18 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 60EA9120A8A; Tue, 13 Aug 2019 18:30:12 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 27230120A2E for ; Tue, 13 Aug 2019 18:30:10 +0900 (JST) Received: by filter0016p3iad2.sendgrid.net with SMTP id filter0016p3iad2-22663-5D528322-5B 2019-08-13 09:30:10.93435637 +0000 UTC m=+1520533.705733170 Received: from herokuapp.com (unknown [3.81.120.68]) by ismtpd0012p1iad1.sendgrid.net (SG) with ESMTP id XsFmdbYOTFK2QSCcSW2XTQ for ; Tue, 13 Aug 2019 09:30:10.782 +0000 (UTC) Date: Tue, 13 Aug 2019 09:30:10 +0000 (UTC) From: mtsmfm@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 69867 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15815 X-Redmine-Issue-Author: mtsmfm X-Redmine-Sender: mtsmfm X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?CfU6l76tuPSnceBN7g1ua+hTMkh1av=2FIIi05EkGpscSemdb1jme9g9=2FSbX=2FJ+l?= =?us-ascii?Q?zx7N7+HLB8Up4XzJyM1+I5VtRM7Ejw1+hoK7BbS?= =?us-ascii?Q?Gffma3mAdMQWMW3c3NMGC8fosDsllF2MYoA0Eyt?= =?us-ascii?Q?Vo7Q6WKdlA2ny0K4FTg3przuwZ4om4MSCHrFh2N?= =?us-ascii?Q?k8ZmF5ETlQocOzv8tqs1WzkeRh7EDKcn9TQ=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 94320 Subject: [ruby-core:94320] [Ruby master Feature#15815] Add option to raise NoMethodError for OpenStruct X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15815 has been updated by mtsmfm (Fumiaki Matsushima). koi-san Sorry for being late. I've added https://bugs.ruby-lang.org/issues/15996?next_issue_id=15993&prev_issue_id=15998#note-17 ---------------------------------------- Feature #15815: Add option to raise NoMethodError for OpenStruct https://bugs.ruby-lang.org/issues/15815#change-80707 * Author: mtsmfm (Fumiaki Matsushima) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- GitHub PR: https://github.com/ruby/ruby/pull/2164 Currently, `OpenStruct#method_missing` returns `nil` even if the key isn't registered. ```ruby require 'ostruct' os = OpenStruct.new({a: 1}) os.a #=> 1 os.b #=> nil ``` I'd like to add `exception` option to raise `NoMethodError` in such case. ```ruby require 'ostruct' os = OpenStruct.new({a: 1}, exception: true) os.a #=> 1 os.b #=> NoMethodError ``` ## Use case I sometimes use OpenStruct as a JSON API response wrapper. It's useful to use method call instead of key access (`obj[:key]`) because we can use `Symbol#to_proc` if it's a method (for example `users.map(&:id)`) But I want to prevent typo for a key name. Currently `users.map(&:idd)` just returns `[nil,...]` Even if we have this `exception` option, we can't enable this option for JSON parser easily though: ```ruby JSON.parse(response, object_class: Class.new(OpenStruct) { def initialize(hash); super(hash, exception: true); end }) ``` What do you think? ---- I've searched with "openstruct nomethoderror" on bugs.ruby-lang.org though, please let me know if it's duplicated. https://bugs.ruby-lang.org/search?utf8=%E2%9C%93&scope=&q=nomethoderror+openstruct -- https://bugs.ruby-lang.org/