From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 84B331F731 for ; Thu, 8 Aug 2019 05:50:33 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 8B051120A1F; Thu, 8 Aug 2019 14:50:25 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id CE2E7120A08 for ; Thu, 8 Aug 2019 14:50:23 +0900 (JST) Received: by filter0058p3iad2.sendgrid.net with SMTP id filter0058p3iad2-31931-5D4BB822-12 2019-08-08 05:50:26.336975935 +0000 UTC m=+1076511.861798068 Received: from herokuapp.com (unknown [3.86.66.28]) by ismtpd0015p1iad2.sendgrid.net (SG) with ESMTP id -szOsreVQ4-nwqF8tvMhsw for ; Thu, 08 Aug 2019 05:50:26.339 +0000 (UTC) Date: Thu, 08 Aug 2019 05:50:26 +0000 (UTC) From: ko1@atdot.net Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 69736 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15912 X-Redmine-Issue-Author: deivid X-Redmine-Issue-Assignee: ko1 X-Redmine-Sender: ko1 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?fVTMYOBjtdvXNcWwrscBhLsHItUXVK5L4mtnq0mdcRfj5Qrocx9sVIlXN94SyS?= =?us-ascii?Q?BZTitPjdy0Ob5B5S2GZD=2FWqUb6e2oGafbv+chRk?= =?us-ascii?Q?wWgWodhTRLiuNgVFB3iuUi0n=2FAwTrVius5atJYK?= =?us-ascii?Q?tdtugWNdU5FXvF+=2FkEDEePKyzdji9Vc3LjXixpw?= =?us-ascii?Q?Q=2FxBpB6tY1JyI?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 94194 Subject: [ruby-core:94194] [Ruby master Feature#15912] Allow some reentrancy during TracePoint events X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15912 has been updated by ko1 (Koichi Sasada). In this case, your solution (allow fire different type of trace) because th= e problematic case `:line` event and `:class` event are different. However, maybe it is accidentally. Someone can use `:line` event as usual. `reopen` will allow re-occurrence explicitly by TracePoint users (like byeb= ug), I think. What do you think about it? To introduce `#reopen`, we need to consider about: * name (`reopen`? `allow`? `unmask` like signal mask idiom?). * do we need to pass allowing events? (e.g.: all events except `:line` even= t are allowed) ---------------------------------------- Feature #15912: Allow some reentrancy during TracePoint events https://bugs.ruby-lang.org/issues/15912#change-80488 * Author: deivid (David Rodr=EDguez) * Status: Assigned * Priority: Normal * Assignee: ko1 (Koichi Sasada) * Target version: = ---------------------------------------- I got a report in byebug about byebug being incompatible with zeitwerk. Thi= s one: https://github.com/deivid-rodriguez/byebug/issues/564. This is a pro= blem because zeitwerk is the default Rails code loader, and byebug is the d= efault Rails debugger. Both of these tools rely on the TracePoint API: * Byebug uses a bunch of TracePoint events to stop execution at certain poi= nts in your program. * Zeitwek uses `:class` events to be able to resolve some circular edge cas= es. I investigated the problem and I think the issue is that while stopped at t= he byebug prompt, we're actually in the middle of processing a TracePoint e= vent. That means that further TracePoint events triggered at the byebug's p= rompt will be ignored, because otherwise we could get into an infinite loop= where the handling of events would trigger more events that trigger themse= lves the execution of handlers again. I understand why the TracePoint API does this, but if we could allow some l= evel of reentrancy here, we could probably make these tools play nice toget= her. I figure if we kept a stack of TracePoint event handlers being run, an= d check that the current event type is not already in the stack, we would a= llow :class events to be triggered from :line events, and I think that woul= d allow Zeitwerk to work within byebug. What do you think about this, @ko1? -- = https://bugs.ruby-lang.org/ Unsubscribe: