From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.7 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 659521F461 for ; Sat, 13 Jul 2019 10:37:31 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 685F3120B48; Sat, 13 Jul 2019 19:37:25 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id DDA19120938 for ; Sat, 13 Jul 2019 19:37:22 +0900 (JST) Received: by filter0080p3iad2.sendgrid.net with SMTP id filter0080p3iad2-31348-5D29B464-26 2019-07-13 10:37:24.712766652 +0000 UTC m=+832707.605263210 Received: from herokuapp.com (unknown [34.238.242.141]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id P8sGOKJvQOG5jeFBffsJ5g for ; Sat, 13 Jul 2019 10:37:24.587 +0000 (UTC) Date: Sat, 13 Jul 2019 10:37:24 +0000 (UTC) From: eregontp@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 69236 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15903 X-Redmine-Issue-Author: Eregon X-Redmine-Issue-Assignee: matz X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?KippOI8ZHtTweq7XfQzW93937kJ4QNWwSBuHnaMEcr1C00FMSJPLKBSB0nZz8V?= =?us-ascii?Q?SlVL0QJdNLLGgQRAQheAFZjiJm145HVogxKRWuV?= =?us-ascii?Q?xFSFyOU576IfpTvZDUS7r8axs826PUo2MsXXJE2?= =?us-ascii?Q?zZkX57PP4qiQbQ7u=2F+iWAUkFKE9Y5CA3is2onf0?= =?us-ascii?Q?g38Df10NuWwKmxtE9CnVJ6ClHTiQcwt239Q=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 93740 Subject: [ruby-core:93740] [Ruby master Feature#15903] Move RubyVM.resolve_feature_path to Kernel.resolve_feature_path X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15903 has been updated by Eregon (Benoit Daloze). Thanks for the decision, and thanks to @nobu for already moving the method. I noticed the documentation is still on RubyVM, I'll try to fix that. ---------------------------------------- Feature #15903: Move RubyVM.resolve_feature_path to Kernel.resolve_feature_path https://bugs.ruby-lang.org/issues/15903#change-79377 * Author: Eregon (Benoit Daloze) * Status: Closed * Priority: Normal * Assignee: matz (Yukihiro Matsumoto) * Target version: 2.7 ---------------------------------------- RubyVM contains mostly MRI-specific features but `resolve_feature_path` is clearly not MRI-specific. So I propose to move it as a class method of `Kernel`. I think this makes sense given the related `load` and `require` are defined in `Kernel` too. Moreover, moving this method outside `RubyVM` is *necessary* for other Ruby implementations to implement it, and keep the clean separation that `RubyVM` is only defined on MRI (see #15752). So, can I move `RubyVM.resolve_feature_path` to `Kernel.resolve_feature_path`? Do we need to keep the method on RubyVM (and deprecate it), or can we just remove it since anyway API under RubyVM is not stable? cc @mame -- https://bugs.ruby-lang.org/