[ruby-core:67591] [ruby-trunk - Bug #10741] [Open] const_defined? triggers autoload where it did not before

[ruby-core:67591] [ruby-trunk - Bug #10741] [Open] const_defined? triggers autoload where it did not before

[headius]

Issue #10741 has been reported by Charles Nutter.

----------------------------------------
Bug #10741: const_defined? triggers autoload where it did not before
https://bugs.ruby-lang.org/issues/10741

* Author: Charles Nutter
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: 2.0.0
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
This should not cause b.rb to load, but it does in 2.2:

~/projects/jruby $ cat a.rb
module Foo
  autoload :Bar, 'b.rb'
end

p Foo.const_defined?('Bar')

~/projects/jruby $ cat b.rb
puts "in b"
module Foo
  Bar = 1
end

~/projects/jruby $ rvm ruby-2.0 do ruby -I. a.rb
true

~/projects/jruby $ rvm ruby-2.1 do ruby -I. a.rb
in b
true

~/projects/jruby $ rvm ruby-2.2 do ruby -I. a.rb
in b
true

This is likely caused by the :: support in const_get/const_defined not doing autoload-free traversal.



-- 
https://bugs.ruby-lang.org/

[ruby-core:67592] [ruby-trunk - Bug #10741] const_defined? triggers autoload where it did not before

[headius]

Issue #10741 has been updated by Charles Nutter.


Test in JRuby that caught this change: https://github.com/jruby/jruby/blob/master/test/jruby/test_autoload.rb#L4-L24

Fix in JRuby: https://github.com/jruby/jruby/commit/496c638d2419e089e93eec9759d9775de0390901

----------------------------------------
Bug #10741: const_defined? triggers autoload where it did not before
https://bugs.ruby-lang.org/issues/10741#change-51012

* Author: Charles Nutter
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: 2.0.0
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
This should not cause b.rb to load, but it does in 2.2:

~/projects/jruby $ cat a.rb
module Foo
  autoload :Bar, 'b.rb'
end

p Foo.const_defined?('Bar')

~/projects/jruby $ cat b.rb
puts "in b"
module Foo
  Bar = 1
end

~/projects/jruby $ rvm ruby-2.0 do ruby -I. a.rb
true

~/projects/jruby $ rvm ruby-2.1 do ruby -I. a.rb
in b
true

~/projects/jruby $ rvm ruby-2.2 do ruby -I. a.rb
in b
true

This is likely caused by the :: support in const_get/const_defined not doing autoload-free traversal.



-- 
https://bugs.ruby-lang.org/

[ruby-core:67593] [ruby-trunk - Bug #10741] const_defined? triggers autoload where it did not before

[headius]

Issue #10741 has been updated by Charles Nutter.


To be more specific, this assertion fails on MRI:

>assert_equal("#{File.dirname(__FILE__)}/autoloaded.rb", Object.autoload?("Autoloaded"))

Because the previous const_defined? call has already triggered the autoload.

----------------------------------------
Bug #10741: const_defined? triggers autoload where it did not before
https://bugs.ruby-lang.org/issues/10741#change-51013

* Author: Charles Nutter
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: 2.0.0
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
This should not cause b.rb to load, but it does in 2.2:

~/projects/jruby $ cat a.rb
module Foo
  autoload :Bar, 'b.rb'
end

p Foo.const_defined?('Bar')

~/projects/jruby $ cat b.rb
puts "in b"
module Foo
  Bar = 1
end

~/projects/jruby $ rvm ruby-2.0 do ruby -I. a.rb
true

~/projects/jruby $ rvm ruby-2.1 do ruby -I. a.rb
in b
true

~/projects/jruby $ rvm ruby-2.2 do ruby -I. a.rb
in b
true

This is likely caused by the :: support in const_get/const_defined not doing autoload-free traversal.



-- 
https://bugs.ruby-lang.org/

[ruby-core:67594] [ruby-trunk - Bug #10741] const_defined? triggers autoload where it did not before

[headius]

Issue #10741 has been updated by Charles Nutter.


Boo...my fix was bad because it stopped searching superclasses. Since I did not have an appropriate method to search superclasses, split up :: elements, and check private consts all in one, I reverted JRuby to the autoload-inducing state for now: https://github.com/jruby/jruby/commit/ccfee85c717a8235d18c63aacfe5f015f4f14261

Tagged some specs and removed an assertion in JRuby's test: https://github.com/jruby/jruby/commit/cffeaab92d5a893240f6ba35159c29eb4cc8d4d5

----------------------------------------
Bug #10741: const_defined? triggers autoload where it did not before
https://bugs.ruby-lang.org/issues/10741#change-51014

* Author: Charles Nutter
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: 2.0.0
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
This should not cause b.rb to load, but it does in 2.2:

~/projects/jruby $ cat a.rb
module Foo
  autoload :Bar, 'b.rb'
end

p Foo.const_defined?('Bar')

~/projects/jruby $ cat b.rb
puts "in b"
module Foo
  Bar = 1
end

~/projects/jruby $ rvm ruby-2.0 do ruby -I. a.rb
true

~/projects/jruby $ rvm ruby-2.1 do ruby -I. a.rb
in b
true

~/projects/jruby $ rvm ruby-2.2 do ruby -I. a.rb
in b
true

This is likely caused by the :: support in const_get/const_defined not doing autoload-free traversal.



-- 
https://bugs.ruby-lang.org/

[ruby-core:93602] [Ruby master Bug#10741] const_defined? triggers autoload where it did not before

[merch-redmine]

Issue #10741 has been updated by jeremyevans0 (Jeremy Evans).

Status changed from Open to Closed

This was fixed between 2.6 and 2.7.0-preview1:

```
$ ruby26 a.rb  
in b
true

$ ruby27 a.rb  
true
```

----------------------------------------
Bug #10741: const_defined? triggers autoload where it did not before
https://bugs.ruby-lang.org/issues/10741#change-79196

* Author: headius (Charles Nutter)
* Status: Closed
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 2.0.0
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
This should not cause b.rb to load, but it does in 2.2:

~/projects/jruby $ cat a.rb
module Foo
  autoload :Bar, 'b.rb'
end

p Foo.const_defined?('Bar')

~/projects/jruby $ cat b.rb
puts "in b"
module Foo
  Bar = 1
end

~/projects/jruby $ rvm ruby-2.0 do ruby -I. a.rb
true

~/projects/jruby $ rvm ruby-2.1 do ruby -I. a.rb
in b
true

~/projects/jruby $ rvm ruby-2.2 do ruby -I. a.rb
in b
true

This is likely caused by the :: support in const_get/const_defined not doing autoload-free traversal.



-- 
https://bugs.ruby-lang.org/