From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.7 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id E86B41F462 for ; Tue, 18 Jun 2019 14:09:00 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 86E37120A59; Tue, 18 Jun 2019 23:08:53 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id A328D120A4C for ; Tue, 18 Jun 2019 23:08:50 +0900 (JST) Received: by filter0077p3las1.sendgrid.net with SMTP id filter0077p3las1-4485-5D08F073-1D 2019-06-18 14:08:51.306537117 +0000 UTC m=+423192.047330641 Received: from herokuapp.com (unknown [3.83.154.101]) by ismtpd0012p1iad1.sendgrid.net (SG) with ESMTP id AFehSGaRSyepW4YLt12gKQ for ; Tue, 18 Jun 2019 14:08:51.162 +0000 (UTC) Date: Tue, 18 Jun 2019 14:08:51 +0000 (UTC) From: eregontp@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 68711 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15807 X-Redmine-Issue-Author: janosch-x X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?KippOI8ZHtTweq7XfQzW93937kJ4QNWwSBuHnaMEcr1fMGnqxxGBir0caBbrxY?= =?us-ascii?Q?m=2FCGSn6e8bbzB4Xq8WWlWc3u=2FjcpntgNAx2iQbt?= =?us-ascii?Q?tIcmVYJKJN6=2FDODzum3G1tHf8cECi7QxyOz=2FUdu?= =?us-ascii?Q?M8T=2FUxRF42nd9hr9WsStkDFj5=2Fr=2F8trJGOL9Sun?= =?us-ascii?Q?5KufjJ+3lcb2GXLowluXhS3Af8bqbl5q5gQ=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 93224 Subject: [ruby-core:93224] [Ruby trunk Bug#15807] Range#minmax is slow and never returns for endless ranges X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15807 has been updated by Eregon (Benoit Daloze). I think it would make sense for `Enumerable#minmax` to just be `[min, max]`= , and be overridden on some classes if useful (probably rare). ---------------------------------------- Bug #15807: Range#minmax is slow and never returns for endless ranges https://bugs.ruby-lang.org/issues/15807#change-78676 * Author: janosch-x (Janosch M=FCller) * Status: Open * Priority: Normal * Assignee: = * Target version: = * ruby -v: 2.6.3p62 * Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN ---------------------------------------- current situation: - `(1..).minmax` runs forever - `(1..).max` raises "cannot get the maximum of endless range" - `(1..Float::INFINITY).minmax` runs forever - `(1..Float::INFINITY).max` returns instantly - `(1..1_000_000_000).minmax` takes one minute - `(1..1_000_000_000).max` returns instantly my suggestion: - implement `minmax` in range.c, return [`range_min`, `range_max`] - for endless ranges, this will trigger the same error as `max` does - delegate to enum (rb_call_super) only if called with a block (?) i could perhaps provide a PR if you can point me to some information on how= to contribute. cheers! ---Files-------------------------------- range-minmax.patch (2.89 KB) -- = https://bugs.ruby-lang.org/ Unsubscribe: