From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 7DA5C1F462 for ; Thu, 13 Jun 2019 06:12:51 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id CB149120B11; Thu, 13 Jun 2019 15:12:45 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id EAAAA120B0E for ; Thu, 13 Jun 2019 15:12:43 +0900 (JST) Received: by filter0033p3iad2.sendgrid.net with SMTP id filter0033p3iad2-2910-5D01E95D-15 2019-06-13 06:12:45.465263285 +0000 UTC m=+739359.048616572 Received: from herokuapp.com (unknown [52.207.231.138]) by ismtpd0015p1iad2.sendgrid.net (SG) with ESMTP id QmU_FcuYS76u9eZYSbtAFQ for ; Thu, 13 Jun 2019 06:12:45.285 +0000 (UTC) Date: Thu, 13 Jun 2019 06:12:45 +0000 (UTC) From: matz@ruby.or.jp Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 68577 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15836 X-Redmine-Issue-Author: byroot X-Redmine-Sender: matz X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?bXEIHGfdFwsIlBTndiToCp=2Fmc2rfxRD2sZAksRKJIHXoHt+Kt2SI+pWYuSKCmC?= =?us-ascii?Q?+5f7eiW3INKySwwbyd9L06Y6086ogmzWAa8Dhnv?= =?us-ascii?Q?IsUW=2FoXdxj0ChvzBj9llKkYkaq+Dv7q576qekne?= =?us-ascii?Q?BJyN17HFTou2yzncCjcHXfHJuI8FhVJRh1Byxll?= =?us-ascii?Q?2+XHWBlrCjwjV?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 93091 Subject: [ruby-core:93091] [Ruby trunk Feature#15836] [Proposal] Make Module#name and Symbol#to_s return their internal fstrings X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15836 has been updated by matz (Yukihiro Matsumoto). Status changed from Feedback to Rejected The compatibility breakage from changing those methods (especially `Symbol#to_s`) is too big. Sorry. Maybe we should work on `HashWithIndifferentAccess` to improve (memory) performance. Matz. ---------------------------------------- Feature #15836: [Proposal] Make Module#name and Symbol#to_s return their internal fstrings https://bugs.ruby-lang.org/issues/15836#change-78513 * Author: byroot (Jean Boussier) * Status: Rejected * Priority: Normal * Assignee: * Target version: ---------------------------------------- # Why ? In many codebases, especially Rails apps, these two methods are the source of quite a lot of object allocations. `Module#name` is often accessed for various introspection features, autoloading etc. `Symbol#to_s` is access a lot by HashWithIndifferentAccess other various APIs accepting both symbols and strings. Returning fstrings for both of these methods could significantly reduce allocations, as well as sligthly reduce retention as it would reduce some duplications. Also, more and more Ruby APIs are now returning fstrings. `frozen_string_literal`AFAIK should become the default some day, string used as hash keys are now automatically interned as well. ### Backward compatibilty Of course this is not fully backward compatible, it's inevitable that some code in the wild is mutating the strings returned by these methods, but I do believe it's a rare occurence, and easy to fix. ### Implementation I implemented it here: https://github.com/ruby/ruby/pull/2175 -- https://bugs.ruby-lang.org/