From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 4A6171F462 for ; Fri, 31 May 2019 19:31:31 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 3E6D7120AFF; Sat, 1 Jun 2019 04:31:25 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 7904B1209F0 for ; Sat, 1 Jun 2019 04:31:23 +0900 (JST) Received: by filter0081p3iad2.sendgrid.net with SMTP id filter0081p3iad2-5493-5CF1810C-6 2019-05-31 19:31:24.059097248 +0000 UTC m=+698040.703646508 Received: from herokuapp.com (unknown [35.153.69.194]) by ismtpd0038p1mdw1.sendgrid.net (SG) with ESMTP id xbVQIFcgQTSSksi8yCxHdA for ; Fri, 31 May 2019 19:31:23.972 +0000 (UTC) Date: Fri, 31 May 2019 19:31:24 +0000 (UTC) From: mohsen@alizadeh.us Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 68393 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15807 X-Redmine-Issue-Author: janosch-x X-Redmine-Sender: mohsen X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?5AJAHOfgiLiMz1U39DAX9HZdEiqfOW9ejJleQ9i7ykarbMJwo=2FCJDBcINeBdbi?= =?us-ascii?Q?YXwSCKTDQngWjChND3H1A1r=2FkjYxOGYGTJ2GeaD?= =?us-ascii?Q?aFeOb7y46DH2fldzLvcUD4NZTklmk9RVxcRtYTL?= =?us-ascii?Q?srIw3rdRT=2F8iUs8Y=2FB87GOREpwdSRFWvKa=2Fb9Lq?= =?us-ascii?Q?DcJHzqC0kCcQrmsW09+AkNdCyGAdXXKej7g=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 92916 Subject: [ruby-core:92916] [Ruby trunk Bug#15807] Range#minmax is slow and never returns for endless ranges X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15807 has been updated by mohsen (Mohsen Alizadeh). i had the same problem with minmax in Range. I made a MR https://github.com/ruby/ruby/pull/2216 ---------------------------------------- Bug #15807: Range#minmax is slow and never returns for endless ranges https://bugs.ruby-lang.org/issues/15807#change-78292 * Author: janosch-x (Janosch M=FCller) * Status: Open * Priority: Normal * Assignee: = * Target version: = * ruby -v: 2.6.3p62 * Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN ---------------------------------------- current situation: - `(1..).minmax` runs forever - `(1..).max` raises "cannot get the maximum of endless range" - `(1..Float::INFINITY).minmax` runs forever - `(1..Float::INFINITY).max` returns instantly - `(1..1_000_000_000).minmax` takes one minute - `(1..1_000_000_000).max` returns instantly my suggestion: - implement `minmax` in range.c, return [`range_min`, `range_max`] - for endless ranges, this will trigger the same error as `max` does - delegate to enum (rb_call_super) only if called with a block (?) i could perhaps provide a PR if you can point me to some information on how= to contribute. cheers! -- = https://bugs.ruby-lang.org/ Unsubscribe: