ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: merch-redmine@jeremyevans.net
To: ruby-core@ruby-lang.org
Subject: [ruby-core:92812] [Ruby trunk Bug#11512] DelegateClass.#public_{instance_}methods are returning difference values.
Date: Fri, 24 May 2019 05:02:34 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-78186.20190524050233.6f892ec33cb55b90@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-11512.20150907170033@ruby-lang.org

Issue #11512 has been updated by jeremyevans0 (Jeremy Evans).

File fix-delegate-class-method-visibility.patch added

This appears to still be a bug.  The patch needed a little manual help to apply, and the tests needed to be updated, but after those changes, all tests passed.  Attached is an updated patch.  I'll try to commit it next week unless I hear objections.

----------------------------------------
Bug #11512: DelegateClass.#public_{instance_}methods are returning difference values.
https://bugs.ruby-lang.org/issues/11512#change-78186

* Author: kachick (Kenichi Kamiya)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
Is this intended behavior?

A patch is PR#926(https://github.com/ruby/ruby/pull/926)

~~~
require 'delegate'

class Parent
  def parent_public; end

  protected

  def parent_protected; end
end

class Child < Parent
end

class DelegatorChild < DelegateClass(Parent)
end

class Parent
  def parent_public_added; end

  protected

  def parent_protected_added; end
end

ignores = Object.public_instance_methods | Delegator.public_instance_methods

p(Child.public_instance_methods - ignores)                 #=> [:parent_public, :parent_public_added]
p(Child.new.public_methods - ignores)                      #=> [:parent_public, :parent_public_added]

p(DelegatorChild.public_instance_methods - ignores)        #=> got: [:parent_public], expected: [:parent_public, :parent_public_added]
p(DelegatorChild.new(Parent.new).public_methods - ignores) #=> got: [:parent_public, :parent_public_added, :parent_protected]], expected: [:parent_public, :parent_public_added]
~~~

---Files--------------------------------
fix-delegate-class-method-visibility.patch (3.69 KB)


-- 
https://bugs.ruby-lang.org/

      parent reply	other threads:[~2019-05-24  5:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-11512.20150907170033@ruby-lang.org>
2015-09-07 17:00 ` [ruby-core:70678] [Ruby trunk - Bug #11512] [Open] DelegateClass.#public_{instance_}methods are returning difference values kachick1
2019-05-24  5:02 ` merch-redmine [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-78186.20190524050233.6f892ec33cb55b90@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).