From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.0 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 170B81F462 for ; Wed, 22 May 2019 09:29:25 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id A044B120A5B; Wed, 22 May 2019 18:29:20 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 8BD1C120A53 for ; Wed, 22 May 2019 18:29:18 +0900 (JST) Received: by filter0015p3iad2.sendgrid.net with SMTP id filter0015p3iad2-28126-5CE5166E-3A 2019-05-22 09:29:18.975772312 +0000 UTC m=+557409.326474865 Received: from herokuapp.com (unknown [3.81.19.97]) by ismtpd0003p1iad2.sendgrid.net (SG) with ESMTP id IY14Kj0DT0qmslGz1lCsrQ for ; Wed, 22 May 2019 09:29:18.916 +0000 (UTC) Date: Wed, 22 May 2019 09:29:19 +0000 (UTC) From: jean.boussier@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 68265 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15625 X-Redmine-Issue-Author: nelhage X-Redmine-Sender: byroot X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?AchqQMoUBMcQgz7gop0XiYUiatGIY7E61JGsTL4FvjdFtG4VK07nC=2FkrWZ0DF4?= =?us-ascii?Q?ZrgiaTykue4UsNz=2FIy8+nUwK62bnDbYYOymSbcy?= =?us-ascii?Q?J1RY9VtZNDqPQn5L9vOEdIHxXqJVHi3Sthyt5AI?= =?us-ascii?Q?NE3m+oz=2FhfuuicdKa0LasFYezbTbjOP1CsfiH0b?= =?us-ascii?Q?iVOKRQ3jPwPctVw9zs8RVHEZJGcCezIWobw=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 92779 Subject: [ruby-core:92779] [Ruby trunk Bug#15625] Module#name performance has exponential-time worst case by aliased constants X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15625 has been updated by byroot (Jean Boussier). This was fixed in https://bugs.ruby-lang.org/issues/15765 ---------------------------------------- Bug #15625: Module#name performance has exponential-time worst case by aliased constants https://bugs.ruby-lang.org/issues/15625#change-78144 * Author: nelhage (Nelson Elhage) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.6.1p33 (2019-01-30 revision 66950) [x86_64-darwin18] * Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN ---------------------------------------- It's well-known (c.f #11119) that `Module#name` has poor performance on anonymous classes, due to searching the entire constant namespace of the VM. However, we recently discovered that it's even worse than that. In the presence of aliased constants (e.g. `module M; end; Alias = M`), the `find_class_path` method actually searches every *path* to a given module (e.g. it will visit that module under both the `M` and `Alias` names). This can lead to exponential-time behavior in cases of repeated aliases. See the attached test case, where performance gets twice as slow with every additional layer of aliasing: On my laptop: ``` user system total real before 2.183899 0.012151 2.196050 ( 2.355187) user system total real a19 5.614596 0.024394 5.638990 ( 5.702878) user system total real a10 9.204399 0.052817 9.257216 ( 9.391010) user system total real a11 16.184035 0.060854 16.244889 ( 16.561101) ``` Our house style makes extensive use of aliases as an import-like mechanism to provide short names within a given scope. We discovered this bug while exploring an actual performance problem -- this is not just a theoretical report. ---Files-------------------------------- classname.rb (854 Bytes) bug-15625.patch (1.38 KB) -- https://bugs.ruby-lang.org/