From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 17FFC1F462 for ; Wed, 22 May 2019 05:09:28 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id A6D531209CD; Wed, 22 May 2019 14:09:23 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 26EFB1209CF for ; Wed, 22 May 2019 14:09:21 +0900 (JST) Received: by filter0001p3iad2.sendgrid.net with SMTP id filter0001p3iad2-2215-5CE4D982-2C 2019-05-22 05:09:23.024612898 +0000 UTC m=+541840.336225880 Received: from herokuapp.com (unknown [3.81.19.97]) by ismtpd0030p1mdw1.sendgrid.net (SG) with ESMTP id ySY2LcjRTPGd3gDyO7g_8A for ; Wed, 22 May 2019 05:09:22.948 +0000 (UTC) Date: Wed, 22 May 2019 05:09:23 +0000 (UTC) From: matz@ruby.or.jp Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 68243 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15853 X-Redmine-Issue-Author: jeremyevans0 X-Redmine-Issue-Assignee: aycabta X-Redmine-Sender: matz X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?bXEIHGfdFwsIlBTndiToCp=2Fmc2rfxRD2sZAksRKJIHUNqOPdUqqHgZmUfH3Kdw?= =?us-ascii?Q?kuQ5caJHHGYF7HxtGWsY+hKQVR9=2FPmWAafkpWQT?= =?us-ascii?Q?FNN0cHSVSkHXa6crgI0EwoBP4xH8rcadigRIVKK?= =?us-ascii?Q?FCcVpxAWJUOLydkFbs68OfYIuUIGdGNo0LaYGu5?= =?us-ascii?Q?l2rHFJmvhI134?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 92758 Subject: [ruby-core:92758] [Ruby trunk Bug#15853] Fix readline test regression when using Readline 4.3 X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15853 has been updated by matz (Yukihiro Matsumoto). @jeremyevans0 Welcome to the committers. Matz. ---------------------------------------- Bug #15853: Fix readline test regression when using Readline 4.3 https://bugs.ruby-lang.org/issues/15853#change-78123 * Author: jeremyevans0 (Jeremy Evans) * Status: Open * Priority: Normal * Assignee: aycabta (aycabta .) * Target version: * ruby -v: * Backport: 2.4: DONTNEED, 2.5: DONTNEED, 2.6: DONTNEED ---------------------------------------- commit:c754e979d3eeca51f1b13778f19f347df3da656e removed the check for Readline 4.3 in a test. Previously, the whole test was skipped on Readline 4.3. However, it turns out that Readline 4.3 runs the test correctly if you skip the same assertion that is skipped when Reline is used. The attached patch skips that assertion when `Readline::VERSION` is 4.3. We may want to consider dropping this assertion completely, it seems to be readline implementation and version dependent behavior. ---Files-------------------------------- fix-readline-4.3-test-regression.patch (1.3 KB) fix-readline-4.3-test-regression-v2.patch (1.28 KB) fix-readline-4.3-test-regression-v3.patch (1.33 KB) -- https://bugs.ruby-lang.org/