From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id A3BBA1F462 for ; Wed, 22 May 2019 05:05:43 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id DBC201209CE; Wed, 22 May 2019 14:05:37 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id F0F7612093B for ; Wed, 22 May 2019 14:05:35 +0900 (JST) Received: by filter0054p3mdw1.sendgrid.net with SMTP id filter0054p3mdw1-4422-5CE4D8A1-1 2019-05-22 05:05:37.048121177 +0000 UTC m=+541609.407361862 Received: from herokuapp.com (unknown [3.81.19.97]) by ismtpd0010p1iad1.sendgrid.net (SG) with ESMTP id RnkBrQJrReaowxWOjlkDgw for ; Wed, 22 May 2019 05:05:36.858 +0000 (UTC) Date: Wed, 22 May 2019 05:05:37 +0000 (UTC) From: usa@garbagecollect.jp Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 68241 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 14915 X-Redmine-Issue-Author: jeremyevans0 X-Redmine-Sender: usa X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?9Ij0W+xF+66shKwcOf8RvdqxJGkEJjaCZuueI4cieuBYurERZLFzcFBtU5fcdq?= =?us-ascii?Q?GoOubkqzhcFt5=2F7L=2F5oTwqhZqgGJySua5opoXmG?= =?us-ascii?Q?vr1SIPZ7BlAV1N1Npa0Iceem1xJlVj7fm=2FYmlj0?= =?us-ascii?Q?M0STsnycgKJdmJvVrBMZSyEDtZZYgEA42kp5UKw?= =?us-ascii?Q?XFw3GihpjCNvA9P7JAI8LD9lUr9z5o15Afg=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 92756 Subject: [ruby-core:92756] [Ruby trunk Feature#14915] Deprecate String#crypt X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #14915 has been updated by usa (Usaku NAKAMURA). As a matter of practice, OpenBSD still has `crypt`. It means that it's too difficult to remove this function at this timing, IMO. We'll remove it in the future, I guess, but not now. ---------------------------------------- Feature #14915: Deprecate String#crypt https://bugs.ruby-lang.org/issues/14915#change-78121 * Author: jeremyevans0 (Jeremy Evans) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- This method is system and implementation dependent, and the portable usage mentioned in the documentation is not truly portable (doesn't work on OpenBSD) and insecure as it uses DES. For systems that lack a crypt(3) implementation, Ruby will happily substitute a version that only supports DES. It's 2018, using DES should be avoided if at all possible. The only internal usage of String#crypt in Ruby is in Webrick, where it uses DES for basic authentication with an htpasswd file. That could and should be changed to use a more secure hash by default (bcrypt since that's the most secure htpasswd format), or at least allow the user to customize Webrick's authentication. I expect there are few if any users actively using Webrick's htpasswd support. This moves the String#crypt implementation to the string/crypt extension, but leaves the String#crypt core method. The core method prints a deprecation warning, then loads the string/crypt extension. The string/crypt extension undefines the String#crypt core method, then defines the previous implementation. Because extensions use extconf.rb instead of configure for their configuration, this ports the related configure.ac code to extconf.rb. I'm not sure that is done correctly and works on all platforms, it will need testing. For systems that lack a crypt(3) implementation, this modifies the fallback code to only define crypt_r, since that is the only function that String#crypt will call in that case. While the patch just deprecates String#crypt, I think we should plan to remove support from ruby: 2.6: core method deprecated 2.7: core method removed, string/crypt extension ships with ruby 2.8: string/crypt extension moves to external gem, not shipped ---Files-------------------------------- 0001-Deprecate-String-crypt-move-implementation-to-string.patch (20.5 KB) 0001-Deprecate-String-crypt.patch (7.48 KB) 0001-Deprecate-String-crypt.patch (7.35 KB) 0001-Deprecate-String-crypt.patch (7.43 KB) deprecate-string-crypt.patch (6.7 KB) -- https://bugs.ruby-lang.org/