ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: eregontp@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:92669] [Ruby trunk Feature#15833] Some refactors for shared-root array
Date: Wed, 15 May 2019 21:05:50 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-78032.20190515210550.bd24151b06fd3e36@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15833.20190506102939@ruby-lang.org

Issue #15833 has been updated by Eregon (Benoit Daloze).


I think RARRAY_SHARED_ROOT_FLAG could be in internal.h, if you want to expose it outside of array.c but not as public C API.

Longer-term I think we should move struct RArray to internal.h, but that's a much bigger/riskier change so not for this issue obviously :)

----------------------------------------
Feature #15833: Some refactors for shared-root array
https://bugs.ruby-lang.org/issues/15833#change-78032

* Author: wanabe (_ wanabe)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
I wrote some patches for shared-root array.
But I can't decide whether to commit them because they include the modification of public header `include/ruby/ruby.h`.

To ruby core team (I'm not assuming anyone in particular):
Can I modify `include/ruby/ruby.h` by the patches?

The following is descriptions of the patches.

`0001-Name-RArray-member-to-count-reference-of-shared-root.patch` names reference count of shared-root array.
So far, `as.heap.aux.capa` is used as reference count but it is different from the reality, reference count.
This is a follow up of r19824.

`0002-Export-RARRAY_SHARED_ROOT_FLAG.patch` exports RARRAY_SHARED_ROOT_FLAG.
I followed other flags as in RARRAY_EMBED_FLAG or RARRAY_TRANSIENT_FLAG.

`0003-Fix-object-info-of-shared-root-array.patch` is not a refactor but feature request patch based on above ones.
`rb_obj_info` outputs shared-root array info as same as normal array currently, but its capa is not a really "capa" as I said.

---Files--------------------------------
0001-Name-RArray-member-to-count-reference-of-shared-root.patch (1.42 KB)
0002-Export-RARRAY_SHARED_ROOT_FLAG.patch (1.54 KB)
0003-Fix-object-info-of-shared-root-array.patch (1.04 KB)


-- 
https://bugs.ruby-lang.org/

  parent reply	other threads:[~2019-05-15 21:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-15833.20190506102939@ruby-lang.org>
2019-05-06 10:29 ` [ruby-core:92572] [Ruby trunk Feature#15833] Some refactors for shared-root array s.wanabe
2019-05-13 22:42 ` [ruby-core:92635] " eregontp
2019-05-14  0:08 ` [ruby-core:92637] " s.wanabe
2019-05-15 21:05 ` eregontp [this message]
2019-07-29  7:13 ` [ruby-core:93972] [Ruby master " nobu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-78032.20190515210550.bd24151b06fd3e36@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).