From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 3D23A1F45F for ; Wed, 8 May 2019 03:15:28 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id AD1C8120A2F; Wed, 8 May 2019 12:15:22 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id D5FAC120A59 for ; Wed, 8 May 2019 12:15:19 +0900 (JST) Received: by filter0055p3iad2.sendgrid.net with SMTP id filter0055p3iad2-28813-5CD249C8-1A 2019-05-08 03:15:20.4535387 +0000 UTC m=+18301.741559545 Received: from herokuapp.com (unknown [34.228.113.206]) by ismtpd0003p1iad2.sendgrid.net (SG) with ESMTP id zHzPSDPqQYqcn5VsVeYz_Q for ; Wed, 08 May 2019 03:15:20.427 +0000 (UTC) Date: Wed, 08 May 2019 03:15:20 +0000 (UTC) From: ruby-core@marc-andre.ca Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 68076 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15836 X-Redmine-Issue-Author: byroot X-Redmine-Sender: marcandre X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?jp+swDN4yjawvlS938eDTV7AcuBgTjW2xvQn0nZL4RA06jsgo8tGeixnAZcpG=2F?= =?us-ascii?Q?YraMtf6ZxZQ+SnVT=2FRdyH=2FVrX9TKMa2uac7vEay?= =?us-ascii?Q?p09p0NAdrsDd5g5rBoq9eIACRmzW3XS6IJybSdR?= =?us-ascii?Q?Akr+lNbnMVE=2F92FcS7fxbNsYkX4p6XiCp8I4wy7?= =?us-ascii?Q?prtK8YfS5aNwUe0WEKaxEgpAND2feAAefHQ=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 92593 Subject: [ruby-core:92593] [Ruby trunk Feature#15836] [Proposal] Make Module#name and Symbol#to_s return their internal fstrings X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15836 has been updated by marcandre (Marc-Andre Lafortune). Is `HashWithIndifferentAccess` the main rationale behind this request? I have doubts about the usefulness of `HashWithIndifferentAccess` today, now that Rails has protected parameters. Moreover, now that symbols are garbage collected, shouldn't its implementation use symbols for keys instead of strings? ---------------------------------------- Feature #15836: [Proposal] Make Module#name and Symbol#to_s return their internal fstrings https://bugs.ruby-lang.org/issues/15836#change-77954 * Author: byroot (Jean Boussier) * Status: Feedback * Priority: Normal * Assignee: * Target version: ---------------------------------------- # Why ? In many codebases, especially Rails apps, these two methods are the source of quite a lot of object allocations. `Module#name` is often accessed for various introspection features, autoloading etc. `Symbol#to_s` is access a lot by HashWithIndifferentAccess other various APIs accepting both symbols and strings. Returning fstrings for both of these methods could significantly reduce allocations, as well as sligthly reduce retention as it would reduce some duplications. Also, more and more Ruby APIs are now returning fstrings. `frozen_string_literal`AFAIK should become the default some day, string used as hash keys are now automatically interned as well. ### Backward compatibilty Of course this is not fully backward compatible, it's inevitable that some code in the wild is mutating the strings returned by these methods, but I do believe it's a rare occurence, and easy to fix. ### Implementation I implemented it here: https://github.com/ruby/ruby/pull/2175 -- https://bugs.ruby-lang.org/