From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 8F2201F45F for ; Tue, 7 May 2019 15:46:17 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 77E6B1208CF; Wed, 8 May 2019 00:46:12 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 2894D120A6F for ; Wed, 8 May 2019 00:46:09 +0900 (JST) Received: by filter0163p3mdw1.sendgrid.net with SMTP id filter0163p3mdw1-890-5CD1A842-38 2019-05-07 15:46:10.710262102 +0000 UTC m=+1019922.862967670 Received: from herokuapp.com (unknown [34.228.113.206]) by ismtpd0036p1mdw1.sendgrid.net (SG) with ESMTP id 8Ak4on36RVKWqdf7cI2oyg for ; Tue, 07 May 2019 15:46:10.636 +0000 (UTC) Date: Tue, 07 May 2019 15:46:10 +0000 (UTC) From: jean.boussier@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 68072 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15836 X-Redmine-Issue-Author: byroot X-Redmine-Sender: byroot X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?AchqQMoUBMcQgz7gop0XiYUiatGIY7E61JGsTL4FvjcmoUMmKxcR3HMTLVijSO?= =?us-ascii?Q?d0HgO8JdPC1ubBdOPbAtM60MWsQAMo9BQMiGm2C?= =?us-ascii?Q?YlSEeulEeS9iyC6FmEf2Bp7=2F3URMAtFVHUWA5vF?= =?us-ascii?Q?ro08UZq=2FIYonjDdkOj4SsjnBLB1ppRAdG+O3WQ4?= =?us-ascii?Q?1xB9VK1B11yM+6Kiamo448QEJ3Xd6EjDtdw=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 92589 Subject: [ruby-core:92589] [Ruby trunk Feature#15836] [Proposal] Make Module#name and Symbol#to_s return their internal fstrings X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15836 has been updated by byroot (Jean Boussier). @mame very good point. I'll try to run our app against that patch tomorrow. ---------------------------------------- Feature #15836: [Proposal] Make Module#name and Symbol#to_s return their internal fstrings https://bugs.ruby-lang.org/issues/15836#change-77950 * Author: byroot (Jean Boussier) * Status: Feedback * Priority: Normal * Assignee: * Target version: ---------------------------------------- # Why ? In many codebases, especially Rails apps, these two methods are the source of quite a lot of object allocations. `Module#name` is often accessed for various introspection features, autoloading etc. `Symbol#to_s` is access a lot by HashWithIndifferentAccess other various APIs accepting both symbols and strings. Returning fstrings for both of these methods could significantly reduce allocations, as well as sligthly reduce retention as it would reduce some duplications. Also, more and more Ruby APIs are now returning fstrings. `frozen_string_literal`AFAIK should become the default some day, string used as hash keys are now automatically interned as well. ### Backward compatibilty Of course this is not fully backward compatible, it's inevitable that some code in the wild is mutating the strings returned by these methods, but I do believe it's a rare occurence, and easy to fix. ### Implementation I implemented it here: https://github.com/ruby/ruby/pull/2175 -- https://bugs.ruby-lang.org/