From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 69A5D1F45F for ; Tue, 7 May 2019 14:55:06 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id C1DC5120B00; Tue, 7 May 2019 23:55:00 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id EC84E120AD4 for ; Tue, 7 May 2019 23:54:57 +0900 (JST) Received: by filter0056p3iad2.sendgrid.net with SMTP id filter0056p3iad2-4763-5CD19C3B-24 2019-05-07 14:54:51.436290908 +0000 UTC m=+62276.170724375 Received: from herokuapp.com (unknown [34.228.113.206]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id bdI4TU_TSp-BOCtt9FFWhw for ; Tue, 07 May 2019 14:54:51.348 +0000 (UTC) Date: Tue, 07 May 2019 14:54:58 +0000 (UTC) From: hanmac@gmx.de Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 68070 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15836 X-Redmine-Issue-Author: byroot X-Redmine-Sender: Hanmac X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?z6kUDlxbGclXLcwluHLUb5EO6uh6mW1Jn0ZSGyxj3H0bF9xWt4WmT711IPslaP?= =?us-ascii?Q?3w2zjtWsecR35WDAapWOEPu=2Fkzvx2=2FEJUKyeh5q?= =?us-ascii?Q?dVg37xJ8RQhc2tQ8isvHQXpIGJr4wvRz4gO0a2I?= =?us-ascii?Q?8CsqhFZVInsXcf=2FsUXK8PvUmFWCH9Es4zOW0d9I?= =?us-ascii?Q?hOImTASxeAHPC?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 92587 Subject: [ruby-core:92587] [Ruby trunk Feature#15836] [Proposal] Make Module#name and Symbol#to_s return their internal fstrings X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15836 has been updated by Hanmac (Hans Mackowiak). is the String returned by rb_sym2str not always frozen? how is the GC handling in case the Symbol was a dynamic generated one? wouldn't that remove the string that got returned from rb_sym2str too? ---------------------------------------- Feature #15836: [Proposal] Make Module#name and Symbol#to_s return their internal fstrings https://bugs.ruby-lang.org/issues/15836#change-77948 * Author: byroot (Jean Boussier) * Status: Feedback * Priority: Normal * Assignee: * Target version: ---------------------------------------- # Why ? In many codebases, especially Rails apps, these two methods are the source of quite a lot of object allocations. `Module#name` is often accessed for various introspection features, autoloading etc. `Symbol#to_s` is access a lot by HashWithIndifferentAccess other various APIs accepting both symbols and strings. Returning fstrings for both of these methods could significantly reduce allocations, as well as sligthly reduce retention as it would reduce some duplications. Also, more and more Ruby APIs are now returning fstrings. `frozen_string_literal`AFAIK should become the default some day, string used as hash keys are now automatically interned as well. ### Backward compatibilty Of course this is not fully backward compatible, it's inevitable that some code in the wild is mutating the strings returned by these methods, but I do believe it's a rare occurence, and easy to fix. ### Implementation I implemented it here: https://github.com/ruby/ruby/pull/2175 -- https://bugs.ruby-lang.org/