ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: nobu@ruby-lang.org
To: ruby-core@ruby-lang.org
Subject: [ruby-core:92575] [Ruby trunk Bug#15789] Parse error when numbered parameter is used in a lambda that is a default value of other optarg
Date: Mon, 06 May 2019 15:47:07 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-77934.20190506154706.5faea49eb9c35a13@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15789.20190424161804@ruby-lang.org

Issue #15789 has been updated by nobu (Nobuyoshi Nakada).


jeremyevans0 (Jeremy Evans) wrote:
> I think the `ordinary parameter is defined` error makes sense if you consider the block starting at the `->` and not the `{`.  Especially when you consider the older lambda/proc syntax uses the same error:
> 
> ```ruby
> lambda { |a=@1| a }
> # SyntaxError ((irb):1: ordinary parameter is defined)
> ```

I've thought inside braces and outside braces are different.

That is, in this code, the `@1` should mean the parameter of the outer `proc`.
```ruby
proc {->(a = @1) {a}}.call(42)
```

But now I changed the mind.
The scope inside parentheses should be separated from the outside.

----------------------------------------
Bug #15789: Parse error when numbered parameter is used in a lambda that is a default value of other optarg
https://bugs.ruby-lang.org/issues/15789#change-77934

* Author: ibylich (Ilya Bylich)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.7.0dev (2019-04-24 trunk cf930985da) [x86_64-darwin18]
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
Sorry if the name of the ticket is not desccriptive

While working on backporting these commits into a parser gem:
https://github.com/ruby/ruby/commit/6ca9e7cc0785c33f6d382176dbd79d6c91db72fe
https://github.com/ruby/ruby/commit/ae07b66aaa092c59ac9d544c9b582712290dc357

... I've found a weird case that throws a SyntaxError:

``` ruby
> def m(a = ->{@1}); end
SyntaxError ((irb):10: ordinary parameter is defined)
def m(a = ->{@1}); end
             ^~
```

And same errors gets thrown when I pass a lambda with numparams to lambda optarg:
``` ruby
> ->(optarg = ->{@1}) {}
SyntaxError ((irb):1: ordinary parameter is defined)
->(optarg = ->{@1}) {}
               ^~
```

I guess the reason for that is that p->max_numparam should be organized as a stack, not a plain shared value.

---Files--------------------------------
fix-numbered-parameter-in-optarg-default-value.patch (546 Bytes)
fix-numbered-parameter-in-optarg-default-value-v2.patch (1.42 KB)


-- 
https://bugs.ruby-lang.org/

  parent reply	other threads:[~2019-05-06 15:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-15789.20190424161804@ruby-lang.org>
2019-04-24 16:18 ` [ruby-core:92400] [Ruby trunk Bug#15789] Parse error when numbered parameter is used in a lambda that is a default value of other optarg ibylich
2019-05-05  4:28 ` [ruby-core:92542] " merch-redmine
2019-05-05  4:47 ` [ruby-core:92544] " merch-redmine
2019-05-05  7:44 ` [ruby-core:92547] " nobu
2019-05-05 23:36 ` [ruby-core:92568] " merch-redmine
2019-05-06 15:47 ` nobu [this message]
2019-05-09  3:41 ` [ruby-core:92603] " merch-redmine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-77934.20190506154706.5faea49eb9c35a13@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).