From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 13777202BB for ; Sun, 24 Mar 2019 05:39:45 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 782871216EA; Sun, 24 Mar 2019 14:39:38 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 375E51216FB for ; Sun, 24 Mar 2019 14:39:36 +0900 (JST) Received: by filter0171p3mdw1.sendgrid.net with SMTP id filter0171p3mdw1-10318-5C971817-C 2019-03-24 05:39:35.606049254 +0000 UTC m=+470226.214329562 Received: from herokuapp.com (unknown [3.91.227.132]) by ismtpd0010p1iad1.sendgrid.net (SG) with ESMTP id M4966CnZSdKmv9_k_DT7Lg for ; Sun, 24 Mar 2019 05:39:35.546 +0000 (UTC) Date: Sun, 24 Mar 2019 05:39:35 +0000 (UTC) From: glass.saga@gmail.com Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 67449 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15553 X-Redmine-Issue-Author: Glass_saga X-Redmine-Sender: Glass_saga X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?M=2FGPwTERRlgwPZgxDS2xAEKPeXmq663sEIKstA8tPUrqQggEp8V2uKgKJ4ZI0y?= =?us-ascii?Q?YnCNndJmpqJTFbhyc4IqRWMn2YR+MXLNd2pvUSO?= =?us-ascii?Q?LX5h9lFo6ay+izaKEu5x7M=2Fl6O7R6G2iKXKxsiS?= =?us-ascii?Q?lop+GsFvE594uyEHANjTHG8i9B0BCZnj=2F4lxeBu?= =?us-ascii?Q?y6C5+WQfqC1n=2FlgfG8NScBfEnGe5m+wpVaA=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 91962 Subject: [ruby-core:91962] [Ruby trunk Feature#15553] Addrinfo.getaddrinfo supports timeout X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15553 has been updated by Glass_saga (Masaki Matsushita). File patch2.diff added I updated the patch. * get rid of Timeout from ext/socket/lib/socket.rb. If getaddrinfo_a() is not available, timeout is ignored. ---------------------------------------- Feature #15553: Addrinfo.getaddrinfo supports timeout https://bugs.ruby-lang.org/issues/15553#change-77296 * Author: Glass_saga (Masaki Matsushita) * Status: Open * Priority: Normal * Assignee: * Target version: 2.7 ---------------------------------------- Currently, we use Timeout in Net::HTTP and other standard libraries. lib/net/http.rb ``` 945 s = Timeout.timeout(@open_timeout, Net::OpenTimeout) { 946 begin 947 TCPSocket.open(conn_address, conn_port, @local_host, @local_port) 948 rescue => e 949 raise e, "Failed to open TCP connection to " + 950 "#{conn_address}:#{conn_port} (#{e.message})" 951 end 952 } ``` Socket.tcp supports connect_timeout, but Addrinfo.getaddrinfo doesn't support timeout. We need to use Timeout to wait name resolution. In this patch, Addrinfo.getaddrinfo support timeout and Socket.tcp accepts resolv_timeout. It uses getaddrinfo_a(3) if available, otherwise it uses Timeout. We can avoid thread creation to make a TCP connection if getaddrinfo_a(3) is available. ---Files-------------------------------- patch.diff (13.2 KB) patch2.diff (11.6 KB) -- https://bugs.ruby-lang.org/