ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: eregontp@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:91951] [Ruby trunk Bug#15558] Should Exception#exception copy the backtrace?
Date: Fri, 22 Mar 2019 22:41:09 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-77283.20190322224109.023d5cfb1fb86264@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15558.20190123161849@ruby-lang.org

Issue #15558 has been updated by Eregon (Benoit Daloze).


@nobu and other MRI committers: what do you think?

It's somewhat inconsistent with Exception#clone which does copy the backtrace.

Would it make sense to follow JRuby and TruffleRuby's behavior, by copying the backtrace too, here?

----------------------------------------
Bug #15558: Should Exception#exception copy the backtrace?
https://bugs.ruby-lang.org/issues/15558#change-77283

* Author: Eregon (Benoit Daloze)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-linux]
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
Currently it does not on MRI:
```
ruby -e 'begin raise "foo"; rescue => e; c=e.exception "bar"; p c.backtrace; end'
nil
```

But it does on JRuby 9.2.5.0 and TruffleRuby 1.0.0-rc11:
```
truffleruby -e 'begin raise "foo"; rescue => e; c=e.exception "bar"; p e.backtrace; end'
["-e:1:in `<main>'"]
```

This means in some cases, code needs about this difference such as in
https://github.com/asciidoctor/asciidoctor/blob/41da20a47a8da96966ef3ec1c2f509e07e7920e3/lib/asciidoctor.rb#L1322-L1338
More context in:
https://github.com/oracle/truffleruby/issues/1542#issuecomment-456850066



-- 
https://bugs.ruby-lang.org/

  parent reply	other threads:[~2019-03-22 22:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-15558.20190123161849@ruby-lang.org>
2019-01-23 16:18 ` [ruby-core:91232] [Ruby trunk Bug#15558] Should Exception#exception copy the backtrace? eregontp
2019-03-22 22:41 ` eregontp [this message]
2019-03-23 21:43 ` [ruby-core:91960] " eregontp
2019-06-04 12:20 ` [ruby-core:92955] " eregontp
2019-06-05 20:19 ` [ruby-core:92988] " eregontp
2019-07-29  7:56 ` [ruby-core:93982] [Ruby master " ko1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-77283.20190322224109.023d5cfb1fb86264@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).